microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 05:37:20 +03:00
Code Issues Projects Releases Wiki Activity

chore: do not add to the internal action logs (#28365)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/28319
This commit is contained in:
Pavel Feldman 2023-11-27 16:43:47 -08:00 committed by GitHub
parent cea28b2df9
commit 022b36332d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 40 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-core/src/server/trace/recorder/tracing.ts
View File

@ -373,6 +373,8 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
} }
onCallLog(sdkObject: SdkObject, metadata: CallMetadata, logName: string, message: string) { onCallLog(sdkObject: SdkObject, metadata: CallMetadata, logName: string, message: string) {
if (metadata.isServerSide || metadata.internal)
return;
if (logName !== 'api') if (logName !== 'api')
return; return;
const event = createActionLogTraceEvent(metadata, message); const event = createActionLogTraceEvent(metadata, message);

5
packages/trace-viewer/src/traceModel.ts
View File

@ -190,7 +190,10 @@ export class TraceModel {
} }
case 'log': { case 'log': {
const existing = actionMap.get(event.callId); const existing = actionMap.get(event.callId);
existing!.log.push({ // We have some corrupted traces out there, tolerate them.
if (!existing)
return;
existing.log.push({
time: event.time, time: event.time,
message: event.message, message: event.message,
}); });

39
tests/playwright-test/ui-mode-trace.spec.ts
View File

@ -19,7 +19,7 @@ import { test, expect, retries } from './ui-mode-fixtures';
test.describe.configure({ mode: 'parallel', retries }); test.describe.configure({ mode: 'parallel', retries });
test('should merge trace events', async ({ runUITest, server }) => { test('should merge trace events', async ({ runUITest }) => {
const { page } = await runUITest({ const { page } = await runUITest({
'a.test.ts': ` 'a.test.ts': `
import { test, expect } from '@playwright/test'; import { test, expect } from '@playwright/test';
@ -99,7 +99,7 @@ test('should merge screenshot assertions', async ({ runUITest }, testInfo) => {
]); ]);
}); });
test('should locate sync assertions in source', async ({ runUITest, server }) => { test('should locate sync assertions in source', async ({ runUITest }) => {
const { page } = await runUITest({ const { page } = await runUITest({
'a.test.ts': ` 'a.test.ts': `
import { test, expect } from '@playwright/test'; import { test, expect } from '@playwright/test';
@ -118,7 +118,7 @@ test('should locate sync assertions in source', async ({ runUITest, server }) =>
).toHaveText('4 expect(1).toBe(1);'); ).toHaveText('4 expect(1).toBe(1);');
}); });
test('should show snapshots for sync assertions', async ({ runUITest, server }) => { test('should show snapshots for sync assertions', async ({ runUITest }) => {
const { page } = await runUITest({ const { page } = await runUITest({
'a.test.ts': ` 'a.test.ts': `
import { test, expect } from '@playwright/test'; import { test, expect } from '@playwright/test';
@ -150,7 +150,7 @@ test('should show snapshots for sync assertions', async ({ runUITest, server })
).toHaveText('Submit'); ).toHaveText('Submit');
}); });
test('should show image diff', async ({ runUITest, server }) => { test('should show image diff', async ({ runUITest }) => {
const { page } = await runUITest({ const { page } = await runUITest({
'playwright.config.js': ` 'playwright.config.js': `
module.exports = { module.exports = {
@ -175,7 +175,7 @@ test('should show image diff', async ({ runUITest, server }) => {
await expect(page.locator('.image-diff-view .image-wrapper img')).toBeVisible(); await expect(page.locator('.image-diff-view .image-wrapper img')).toBeVisible();
}); });
test('should show screenshot', async ({ runUITest, server }) => { test('should show screenshot', async ({ runUITest }) => {
const { page } = await runUITest({ const { page } = await runUITest({
'playwright.config.js': ` 'playwright.config.js': `
module.exports = { module.exports = {
@ -197,3 +197,32 @@ test('should show screenshot', async ({ runUITest, server }) => {
await expect(page.getByText('Screenshots', { exact: true })).toBeVisible(); await expect(page.getByText('Screenshots', { exact: true })).toBeVisible();
await expect(page.locator('.attachment-item img')).toHaveCount(1); await expect(page.locator('.attachment-item img')).toHaveCount(1);
}); });
test('should not fail on internal page logs', async ({ runUITest, server }) => {
const { page } = await runUITest({
'a.test.ts': `
import { test, expect } from '@playwright/test';
test('pass', async ({ browser }, testInfo) => {
const context = await browser.newContext({ storageState: { cookies: [], origins: [] } });
const page = await context.newPage();
await page.goto("${server.EMPTY_PAGE}");
await page.context().storageState({ path: testInfo.outputPath('storage.json') });
});
`,
});
await page.getByText('pass').dblclick();
const listItem = page.getByTestId('actions-tree').getByRole('listitem');
await expect(
listItem,
'action list'
).toHaveText([
/Before Hooks[\d.]+m?s/,
/browser.newContext[\d.]+m?s/,
/browserContext.newPage[\d.]+m?s/,
/page.goto/,
/browserContext.storageState[\d.]+m?s/,
/After Hooks/,
]);
});