microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-09-21 09:27:30 +03:00
Code Issues Projects Releases Wiki Activity

feat(testrunner): "sourcemapify" crash error stacktraces (#441)

Browse Source 
Whenever test runner crashes due to UnhandledPromiseRejection, the
related error should be run through "sourcemap decoding".
This commit is contained in:
Andrey Lushnikov 2020-01-09 16:37:19 +00:00 committed by GitHub
parent d83d3c3851
commit 02c504ca59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
utils/testrunner/TestRunner.js
View File

@ -260,7 +260,7 @@ class TestPass {
test.result = TestResult.Crashed;
this._runner._didFinishTest(test, workerId);
if (this._breakOnFailure && test.result !== TestResult.Ok)
this._terminate(TestResult.Terminated, `Terminating because a test has failed and |testRunner.breakOnFailure| is enabled`, null);
await this._terminate(TestResult.Terminated, `Terminating because a test has failed and |testRunner.breakOnFailure| is enabled`, null);
}
async _runHook(workerId, suite, hookName, ...args) {
@ -273,19 +273,21 @@ class TestPass {
if (error === TimeoutError) {
const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`;
const message = `${location} - Timeout Exceeded ${hook.timeout}ms while running "${hookName}" in suite "${suite.fullName}"`;
return this._terminate(TestResult.Crashed, message, null);
return await this._terminate(TestResult.Crashed, message, null);
}
if (error) {
const location = `${hook.location.fileName}:${hook.location.lineNumber}:${hook.location.columnNumber}`;
const message = `${location} - FAILED while running "${hookName}" in suite "${suite.fullName}"`;
return this._terminate(TestResult.Crashed, message, error);
return await this._terminate(TestResult.Crashed, message, error);
}
return false;
}
_terminate(result, message, error) {
async _terminate(result, message, error) {
if (this._termination)
return false;
if (error && error.stack)
await this._runner._sourceMapSupport.rewriteStackTraceWithSourceMaps(error);
this._termination = {result, message, error};
for (const userCallback of this._runningUserCallbacks.valuesArray())
userCallback.terminate();
@ -408,10 +410,10 @@ class TestRunner extends EventEmitter {
return result;
}
terminate() {
async terminate() {
if (!this._runningPass)
return;
this._runningPass._terminate(TestResult.Terminated, 'Terminated with |TestRunner.terminate()| call', null);
await this._runningPass._terminate(TestResult.Terminated, 'Terminated with |TestRunner.terminate()| call', null);
}
timeout() {