microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-05 19:04:43 +03:00
Code Issues Projects Releases Wiki Activity

docs: change if: always() to if: !cancelled() (#30102)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/29451

See
https://github.com/microsoft/playwright/issues/29451#issuecomment-2008476721
for investigation.
This commit is contained in:
Max Schmitt 2024-03-25 19:17:05 +01:00 committed by GitHub
parent 82804cce64
commit 032f27ff84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/src/ci-intro.md
View File

@ -65,7 +65,7 @@ jobs:
- name: Run Playwright tests - name: Run Playwright tests
run: npx playwright test run: npx playwright test
- uses: actions/upload-artifact@v4 - uses: actions/upload-artifact@v4
if: always() if: ${{ !cancelled() }}
with: with:
name: playwright-report name: playwright-report
path: playwright-report/ path: playwright-report/
@ -103,7 +103,7 @@ jobs:
- name: Run your tests - name: Run your tests
run: pytest --tracing=retain-on-failure run: pytest --tracing=retain-on-failure
- uses: actions/upload-artifact@v4 - uses: actions/upload-artifact@v4
if: always() if: ${{ !cancelled() }}
with: with:
name: playwright-traces name: playwright-traces
path: test-results/ path: test-results/

4
docs/src/test-sharding-js.md
View File

@ -89,7 +89,7 @@ jobs:
run: npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }} run: npx playwright test --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
- name: Upload blob report to GitHub Actions Artifacts - name: Upload blob report to GitHub Actions Artifacts
if: always() if: ${{ !cancelled() }}
uses: actions/upload-artifact@v4 uses: actions/upload-artifact@v4
with: with:
name: blob-report-${{ matrix.shardIndex }} name: blob-report-${{ matrix.shardIndex }}
@ -104,7 +104,7 @@ jobs:
... ...
merge-reports: merge-reports:
# Merge reports after playwright-tests, even if some shards have failed # Merge reports after playwright-tests, even if some shards have failed
if: always() if: ${{ !cancelled() }}
needs: [playwright-tests] needs: [playwright-tests]
runs-on: ubuntu-latest runs-on: ubuntu-latest