microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-05 19:04:43 +03:00
Code Issues Projects Releases Wiki Activity

browser(webkit): disable GPU process on Windows only (#10193)

Browse Source 
- GPU Process was enabled by default on Windows recently: 2058f94543
- We tried it and it fails a bunch of tests: https://github.com/microsoft/playwright/pull/10156
- Curiously, disabling it on Mac fixes a mac-related bug: https://github.com/microsoft/playwright/pull/10170, however we're scared of the change
This commit is contained in:
Andrey Lushnikov 2021-11-09 11:00:05 -08:00 committed by GitHub
parent d34f9972ab
commit 06c587b696
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser_patches/webkit/BUILD_NUMBER
View File

@ -1,2 +1,2 @@
1575
Changed: lushnikov@chromium.org Mon Nov 8 18:03:39 HST 2021
1576
Changed: lushnikov@chromium.org Tue Nov 9 08:50:26 HST 2021

18
browser_patches/webkit/patches/bootstrap.diff
View File

@ -10101,24 +10101,26 @@ index 26ad3e0b3fcbc818f99fcb7ae06eb75e95e1a2d1..989137fd39ca671a449517120f4ec01e
GtkSettingsState gtkSettings;
#endif
diff --git a/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp b/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
index 2d1c6dc88b16b7be6b9b14e8806d758ca176a7a8..a10088a42873a6e06822730c89b9a6559c17989c 100644
index 2d1c6dc88b16b7be6b9b14e8806d758ca176a7a8..c226107217233063822cb4d0c356f6333edabd2a 100644
--- a/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
+++ b/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
@@ -163,7 +163,7 @@ bool defaultOfflineWebApplicationCacheEnabled()
@@ -162,7 +162,9 @@ bool defaultOfflineWebApplicationCacheEnabled()
bool defaultUseGPUProcessForCanvasRenderingEnabled()
{
#if ENABLE(GPU_PROCESS_BY_DEFAULT) || PLATFORM(WIN)
- bool defaultValue = true;
+ bool defaultValue = false; // Playwright: force false
-#if ENABLE(GPU_PROCESS_BY_DEFAULT) || PLATFORM(WIN)
+#if PLATFORM(WIN)
+ bool defaultValue = false; // Playwright: force-disable on Windows
+#elif ENABLE(GPU_PROCESS_BY_DEFAULT)
bool defaultValue = true;
#else
bool defaultValue = false;
#endif
@@ -190,7 +190,7 @@ bool defaultUseGPUProcessForMediaEnabled()
@@ -190,7 +192,7 @@ bool defaultUseGPUProcessForMediaEnabled()
bool defaultUseGPUProcessForWebGLEnabled()
{
#if PLATFORM(WIN)
- bool defaultValue = true;
+ bool defaultValue = false; // Playwright: force false
+ bool defaultValue = false; // Playwright: force disable on Windows
#else
bool defaultValue = false;
#endif