From 0efa4a90cc3129ad297b33d8ede94b6401f69990 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 5 Oct 2023 23:08:43 +0000 Subject: [PATCH] devops: Node.js 16 -> Node.js 18 (#27467) As per https://github.com/microsoft/playwright-internal/blob/main/INFRASTRUCTURE.md. Fixes https://github.com/microsoft/playwright/issues/27148. --- .github/workflows/create_test_report.yml | 2 +- .github/workflows/infra.yml | 2 +- .github/workflows/publish_canary.yml | 2 +- .github/workflows/publish_release_docker.yml | 2 +- .github/workflows/publish_release_driver.yml | 2 +- .../workflows/publish_release_traceviewer.yml | 2 +- .../roll_browser_into_playwright.yml | 2 +- .github/workflows/tests_components.yml | 8 ++- .github/workflows/tests_electron.yml | 2 +- .github/workflows/tests_primary.yml | 18 +++--- .github/workflows/tests_secondary.yml | 60 +++++++++---------- .github/workflows/tests_video.yml | 2 +- .../trigger_build_chromium_with_symbols.yml | 2 +- 13 files changed, 56 insertions(+), 50 deletions(-) diff --git a/.github/workflows/create_test_report.yml b/.github/workflows/create_test_report.yml index d6be2e0336..fe33aa0dae 100644 --- a/.github/workflows/create_test_report.yml +++ b/.github/workflows/create_test_report.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: diff --git a/.github/workflows/infra.yml b/.github/workflows/infra.yml index c63d494e18..d3a3fa0030 100644 --- a/.github/workflows/infra.yml +++ b/.github/workflows/infra.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci - run: npm run build - run: npx playwright install-deps diff --git a/.github/workflows/publish_canary.yml b/.github/workflows/publish_canary.yml index 9ecff84367..4ff33481de 100644 --- a/.github/workflows/publish_canary.yml +++ b/.github/workflows/publish_canary.yml @@ -77,7 +77,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - name: Deploy Canary run: bash utils/build/deploy-trace-viewer.sh --canary if: contains(github.ref, 'main') diff --git a/.github/workflows/publish_release_docker.yml b/.github/workflows/publish_release_docker.yml index 98ef1a91f2..31a361e564 100644 --- a/.github/workflows/publish_release_docker.yml +++ b/.github/workflows/publish_release_docker.yml @@ -23,7 +23,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 registry-url: 'https://registry.npmjs.org' - uses: azure/docker-login@v1 with: diff --git a/.github/workflows/publish_release_driver.yml b/.github/workflows/publish_release_driver.yml index c807a925c9..56c9201bcd 100644 --- a/.github/workflows/publish_release_driver.yml +++ b/.github/workflows/publish_release_driver.yml @@ -16,7 +16,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 registry-url: 'https://registry.npmjs.org' - run: npm ci - run: npm run build diff --git a/.github/workflows/publish_release_traceviewer.yml b/.github/workflows/publish_release_traceviewer.yml index ac4986f1e2..0d41425774 100644 --- a/.github/workflows/publish_release_traceviewer.yml +++ b/.github/workflows/publish_release_traceviewer.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - name: Deploy Stable run: bash utils/build/deploy-trace-viewer.sh --stable env: diff --git a/.github/workflows/roll_browser_into_playwright.yml b/.github/workflows/roll_browser_into_playwright.yml index 8b78c9cf1f..c474f848df 100644 --- a/.github/workflows/roll_browser_into_playwright.yml +++ b/.github/workflows/roll_browser_into_playwright.yml @@ -14,7 +14,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci - run: npm run build - name: Install dependencies diff --git a/.github/workflows/tests_components.yml b/.github/workflows/tests_components.yml index cf784a682e..0da0986ee1 100644 --- a/.github/workflows/tests_components.yml +++ b/.github/workflows/tests_components.yml @@ -24,12 +24,18 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, macos-latest, windows-latest] + node-version: [18] + include: + - os: ubuntu-latest + node-version: 16 + - os: ubuntu-latest + node-version: 20 runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: ${{ matrix.node-version }} - run: npm ci - run: npm run build - run: npx playwright install --with-deps diff --git a/.github/workflows/tests_electron.yml b/.github/workflows/tests_electron.yml index 0feadb7f3b..193c82f71f 100644 --- a/.github/workflows/tests_electron.yml +++ b/.github/workflows/tests_electron.yml @@ -31,7 +31,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index 9ef8c8f702..86365a6345 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -33,10 +33,10 @@ jobs: matrix: browser: [chromium, firefox, webkit] os: [ubuntu-22.04] - node-version: [16] + node-version: [18] include: - os: ubuntu-22.04 - node-version: 18 + node-version: 16 browser: chromium - os: ubuntu-22.04 node-version: 20 @@ -77,7 +77,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -103,14 +103,14 @@ jobs: fail-fast: false matrix: os: [ubuntu-latest, windows-latest, macos-latest] - node-version: [16] + node-version: [18] shard: [1/2, 2/2] include: - os: ubuntu-latest - node-version: 18 + node-version: 16 shard: 1/2 - os: ubuntu-latest - node-version: 18 + node-version: 16 shard: 2/2 - os: ubuntu-latest node-version: 20 @@ -153,7 +153,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -186,7 +186,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -229,7 +229,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install diff --git a/.github/workflows/tests_secondary.yml b/.github/workflows/tests_secondary.yml index 6b55894b75..5bb5cf0591 100644 --- a/.github/workflows/tests_secondary.yml +++ b/.github/workflows/tests_secondary.yml @@ -27,13 +27,13 @@ jobs: fail-fast: false matrix: browser: [chromium, firefox, webkit] - os: [ubuntu-20.04, ubuntu-22.04] + os: [ubuntu-20.04] runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -65,7 +65,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -95,7 +95,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -123,7 +123,7 @@ jobs: matrix: include: - os: ubuntu-latest - node_version: 18 + node_version: 16 - os: ubuntu-latest node_version: 20 timeout-minutes: 30 @@ -159,7 +159,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -194,7 +194,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -230,7 +230,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install @@ -258,7 +258,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -284,7 +284,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -311,7 +311,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -341,7 +341,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -377,7 +377,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -409,7 +409,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -435,7 +435,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -462,7 +462,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -488,7 +488,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -514,7 +514,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -541,7 +541,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -567,7 +567,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -593,7 +593,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -620,7 +620,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -646,7 +646,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -672,7 +672,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -699,7 +699,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -725,7 +725,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -751,7 +751,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -778,7 +778,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -804,7 +804,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci - run: npm run build - run: npx playwright install-deps @@ -817,7 +817,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install diff --git a/.github/workflows/tests_video.yml b/.github/workflows/tests_video.yml index fcde10775a..54c97bedca 100644 --- a/.github/workflows/tests_video.yml +++ b/.github/workflows/tests_video.yml @@ -25,7 +25,7 @@ jobs: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: 16 + node-version: 18 - run: npm ci env: DEBUG: pw:install diff --git a/.github/workflows/trigger_build_chromium_with_symbols.yml b/.github/workflows/trigger_build_chromium_with_symbols.yml index b9dfe00fca..e0e31acd57 100644 --- a/.github/workflows/trigger_build_chromium_with_symbols.yml +++ b/.github/workflows/trigger_build_chromium_with_symbols.yml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v2 - uses: actions/setup-node@v2 with: - node-version: '16' + node-version: 18 - name: Get Chromium revision id: chromium-version run: |