From 1196b4f0f587eec4e889c4ab51afce3082dff642 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Tue, 24 Jan 2023 14:00:10 -0800 Subject: [PATCH] chore: do not use docker for "Web Components" tests (#20339) --- .github/workflows/tests_primary.yml | 9 +-------- packages/html-reporter/playwright.config.ts | 1 - .../chromium/chip.spec.tsx/expand-collapse-1.png | Bin 2554 -> 0 bytes .../chip.spec.tsx/render-long-title-1.png | Bin 5833 -> 0 bytes packages/html-reporter/src/chip.spec.tsx | 2 -- 5 files changed, 1 insertion(+), 11 deletions(-) delete mode 100644 packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/expand-collapse-1.png delete mode 100644 packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/render-long-title-1.png diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index d54b8a503d..eed38d676e 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -144,14 +144,7 @@ jobs: DEBUG: pw:install - run: npm run build - run: npx playwright install --with-deps - - run: | - ./utils/docker/build.sh --amd64 focal $PWTEST_DOCKER_BASE_IMAGE - npx playwright docker build - nohup npx playwright docker start & - xvfb-run npm run test-html-reporter - env: - PLAYWRIGHT_DOCKER: 1 - PWTEST_DOCKER_BASE_IMAGE: playwright:localbuild + - run: xvfb-run npm run test-html-reporter - run: xvfb-run npm run test-web if: always() diff --git a/packages/html-reporter/playwright.config.ts b/packages/html-reporter/playwright.config.ts index fe52192bee..41140fb50c 100644 --- a/packages/html-reporter/playwright.config.ts +++ b/packages/html-reporter/playwright.config.ts @@ -20,7 +20,6 @@ export default defineConfig({ testDir: 'src', forbidOnly: !!process.env.CI, retries: process.env.CI ? 2 : 0, - ignoreSnapshots: !process.env.PLAYWRIGHT_DOCKER, snapshotPathTemplate: '{testDir}/__screenshots__/{projectName}/{testFilePath}/{arg}{ext}', reporter: 'html', use: { diff --git a/packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/expand-collapse-1.png b/packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/expand-collapse-1.png deleted file mode 100644 index 6b858f6c859224ad1ec76bf86ac6887c46545c1d..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 2554 zcmb7G`#%%vAAjUfhjcpU`<;}m+`~a3HJ9khC=N3#Q#eR$vrcX;H0gWl98P4cmBZwo z$ut=?rli_o%ynCtsc22c-0#MB&L8mozRoYt^Zw!UdS1`xd0(E-?>~9DX=&`z003yg z-B0)epz>LX;ak*|>lhlDtlU&$eBF)#I&b$^0KTn-pE&AwHE&!@2tpFNGD@z1Tfyk_=d{+gTY4f8nsCpfv6ow0V|RI0 z!c|lle%S9%sZEfVZnCbaN@`v^SFbj%vlg5>3A~BPPRdN4bRcxO6Gb3z0$^LXLt;~^ zt2%huoC{+q@8!Bz6$Eej#s&cOzajW1@RsIh=Ypi7hh6*6P?ujrRt9XX&KxZaY2$X{ zU$p_SIDXjau1kMjg|gs5$3-})AT!gXB^}z#QY> zB~5e{-h>h^70o4vgcN3I|JyF^8~}D^w=d|M8kLT;WY)QpqO~-I4H%*5^tp(OIOOTT zBBRLeq0+Q8XyEW+(1Ro&y0~9 zx1m0~483a~o9q-zS+|+VBA2$^3bHdW7s66wBp&r7`|$;GlvyURW_!j z79$rZPwR20v(=8+{df|N4f2@bXAZ3(Ru?Fo8>iPfDwh$2paH{7ahkDA`)NYYF zwa5sS$mR4|t(^{ef1<0LixTj^-cpx|@R^vo1{sa%2!lm-zfwzsb_Jp9!bYng77!?u zt~Rr#Z)#eu&Q}Mnhy(e~K|Wtc3;=j0fUTC>ssM0fD@f7b{+F`jzoE)MhAA_LmN>i5 zE14HMA;QCrtAoB#I_iFn(pO+h7yw&SHZ1o4;V#R&TrL-~U8l%;8b3w)uRAIy~!aWaFU5&|FO-k1F+Yi7Cw|KSb8=c>c%72N}*v2{;b0NW)t?)8I%ZrNo=Dq^HOv16wh&Y7y*hH=$0sBt2uZ)r#36zcWOa~A!N~ImwzZBCm5pqtgHrMm|7~nMjkUjX zF*tkhLY;dDOvIT74vMt6)rqll;{$UHn?ZCjvvRP2< zA4gCHP0o&U9~F_gHaOPY_4!`gi>=rL7-`*UOZ2Le2k-g}N1G%5J9S<9B-ZS<_BQ{4 z-##%FkpNt>W2#^2X3!Rl6EsJngeesXrH?Qa9&3#yvx}W{l|inYA+6^;x@Rd4vw0AU z@*vI2Mb)+u9+)w-k53^y)0t+EqoXLi{G6Qa<>N3%V>m|mqB?8Juy0tf{UBccxbV2T z+2IlG@My8g)Ax_Z#$g`1hfYDE@~96ybm#<}nW1Zo{msLRJkqOJzh?x|*8Vz~75HYW z?$5%dO`uCBN-He8Vs!Ay8!Q9!a@%!^HtzXzRz+jcP+GFWaq*l>Vj=-f@}fE*LxU(^ zIwZ2;P=#D3E1vMmyK4l2Kq{5J*ee=hh*Kv`4evgKv#4T2P>Khve%7TuqZo%=|dw$ith-+>45B#y0uZ$=pW^X-S zT6Op1UN$Q@ggI$xVSzZEM5?Kat`s(FYG_s!q^Drr=-xovHJzE}Foh%58s zM)0+@>wGGn*TEHPt*uQ@&*rp-`TjChsuoIEa>Fgpvki|~Sy=_FUuR8EPea5mH5a5C zdHbH(wu~nxA0rT!Jm7l8d3p`8i|%y$h-jq8=vl(mXO;MZ->&H;DFbX){Cl>!r6qqT zoXeNZ?`KBwX>Xg9N9H=>Z}9RRtBXS4T*J3)-sN;T#mEd6S<+)`|MjJGbKIxYa~qo4 zvH3eQtN3RF1A%eqPG~^w?3w%{3bsaiMkIffX&G42_o>84y85XFN@XR6&D#u8 zmTP3N&oAY~KGs2t*|t^T!SMcAGMQYV*wc?$>}tLi{E8jbU38Ke8JuWj@;Y+$Kfjyr z+vm3+KNL0iA&AB(c#pkDDKAgG87+8O$Z$xM=c%7u5I#GA%rw!09(Hxh)E;4&^~SP3 z*E+*C>!^a=L%BpzZ{G82^8+xXs=>;}!xeK?Kw$B1n{Z`JV9(E>HnLx3;~V&2 m*`G3Vqk2Z~@04#`SCzYRvkE@Reo+oh0DjWz1pQcW>VE+zLCXvP diff --git a/packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/render-long-title-1.png b/packages/html-reporter/src/__screenshots__/chromium/chip.spec.tsx/render-long-title-1.png deleted file mode 100644 index 30ceb67e4b620e8d7f42fee9f89737be81ffc4ca..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 5833 zcmbtYWmr^gw;n{05PVS(kP=C0LAqPILxvKDZjcy;QdB_cbVz9t7$k@88oDF~8IZ04 zN$L5v?>WEEkMqrsJ$voz+Ut4tTKBr2d#xy4ZB;UoMg^Ko7&!l;jNqGO-K(rj#>}`VRK_zCYIQ28k$DcAJ8P6U}Y$ zdp=m`8S3)P#yqR+z7LCe)MFi^7Oj#$%l0Uroy#;*9Z_jrY$``EMb|+{`cw9yF%hSR zp6EqLc3+>@`p^)3#RKZ#U{Bp+Mg3%wLV<|6+odqznDr$|)jtYE2kB3({O`O2?wAQ) z5;4CUBh`<84_MNV|Hs7t?@X&aOz^emw-p75p<(L`nREz!u>@Z`bdw!P#+bNBlH4Sn}c-;@G`d2ho{Sxa`*R6M4Z2lTgH~q##mFu zqQ+bsLIK`gt8<*rwUUV=sD=)AmFpI5v)`fDXsLL>lu+BHfcd2rM>xMM25fG(N!28-@ zS|~4VWo2cq`vO{g9o%MHK6#OtkhYOyd+9OUKUhRf@Ul?Q=H};I1D_;JB-1kZLJyVu zBtrzzH#QdUBxGOhJMY&U{RmaZAg`pPbW3-pP{vA=CZaq>m_>#`i=WBEy|>$Q`HWa0 zjxZ@Rb7(otj$X_&{_NfDZziE}#4Ek}*DcPh(n0;IWELfQ`4S5)jmvFfpjxxxFK7@%5f&!vGZQ`!+I9Ta0;U30 zFv^(M2SlB?gj%m>HYh18ub7rTtai{WG~Ch$?JhLsoReOwX$FOzC!tz&ir1> zd?|h*?J^>DOVo|fdTi-ejq6;dxKObH5P;5k^qzowFHg3H zJC*TR+1VzV;dBq!qZRESw^#XDvZPwPqurn|$(F(X^xB;>=W!dUrq}j|)GKlisx)X5nF{fYv3j_-lc zHSQ@JVyx`!6V)b6v5b-`Y1&!8vDmITpI>LkdxKao5>H@2>;v3qeWK7n6;lC@NP6|^ z><$m!68gj?nn5-Jx6q~ofSyqnI<#Is4-(Mj^4_hspu3luNsqU=GEd4s$~TvqLB&7P zuk!)l+QVZM$W~?L2(;)t&x@bLLtRCp#s$AUS8){M#VA>Xij061=zip4DJdzr%Xs<> zsOh_mn|&Ni_coT^C=O)`QwNB&w(ZV+%FU(V{kaeo6=QdpOuI`&k{4HTFY4ZXIMSNJ ze;+gWr;=KPrC2+w*JDX{?`M?lQrJzsuu~^u0Y)R>N#x|@G$+Vd@5Ft5d1()kh|KZF z5+3Fx{OlFs4o1D;&&d{(l&l2Gyt8Yx`ldJrDDw%V&c2C$G;pb{C?n*nY=3? z+w^48Y77p2LH^4JD;y1$GjTdEK-T?BZwwKu?T1v00=^fT(J?V_aW_Hr!uz74CYqWb z@y1%q?~qe*=M51lJ3DhN23Nn;%L(aR>C+*)ICoGtdwGEB>vG(lekaq4>F(=$Ku`Zx zKlkOvejAejbUEPS&yFGhJ>AkD0X5E1CZalx{`(~D4M)_V+0O?f)~o$-PCvgg=c~l9 zN=s+)f{`0yDs(O`kAe(yHeF^STm8twY*iKYxKe=Pl^T79ZuX`7v$s$To&jk8`e|1L zd6AWsRklp9`qDaY*t)l1n19^f>mBs_lB71!(o~5M=&H(rX=`gMz;|chcWyXb62@NW z>Lx6yyBfqSF8(90*+Lw&J%fu6JgI7nH{_z)(-Qs@rk+}pXM5@QIU~ctC26L9XWOkm zvee}P4=*nfxwvLvpoC724BPG~PQM`$f8PiuI{GYdUg*B}>WkQ*n*GfZi@$|T@lZtx zLJ3rGo2=dEN7)j-`9?J4SyC)!gsRmbv|IEfD_B+T@fnM%5zB@xy$&q zq2h9;WK!-%C~o@6H>(@JkDBQ6sgAk7jUZQl=lQH>5rZK=Sk zNS0g<(B^(A^gBm2jp)~Xg;Dpc!-c4g1*YdHF-4;iL%_%T?3N2pU`3Tsk^3;%r4$mJ zA4nD*{XBx^0iA~W$8^}A{UiBnl{vIBz{%_A+aL`M(z5bJy!PJSheXBtYVZVVqd=1%THOlq3XEYEht{A6rt~#KWqqg-j4Cs|~of11|p(w^E`0 z_%}OJfboA_os(Yeci;oq_%qKc^Nf<6#iWK7dKz01c;cLSmz0HzEB&6V zCtiDJXJ(b%;4NK=731FU0@kJBkrzEAR5T)xe@L&}2(5dMOVESI6$-8U%$MhZ_>P~v zCAQEunGHN`majtv43t)@RTud!TMH)rKEcx+i(_Jh(`*KkdAqK}tE*}U&Hf=H%OO)+ zpUZorFQk*;b()c#jo3m)718hzn<^2L4)R-vdFM@U@IgzwLz!#YSo@O<5EcXVg&QWt;+ z8actdeCh?JA;a0|uhGJjS{aSwqezoFKfp2TRVNg5H>S#7DGG3AnWfA5JhZsDn0j;e z6FbZ3VSIMcdE4kNQa7|cb-;xjpognb+QF#dj6@36zVyEonY&~i%OLroy86MIAf{w>O>6jtnb{+UkxVwJ z6%jdkDrJ@3!Fjyje-?3FC=>;-X>1pay+<><33Eir>hm7;V!il&XIEG4(TKgK36zQ! z+A-^#+J=dyC%X>MlHJc!CiNefpF8-W5W2j)Tr;?`ye#Ik&g1XCI6fljvrg|YDnmC4 zu0;NQ2oT9p3+|Sz9d=_U#_5@sHHkM|qI7jN* z{zx_MgP`p?eVqq!_t4N?QXe5;4bx4WFk`tl4%CvH%Zx<_e0Nj*CtoG5P(D0vw%&>K z;K0jut_H7qx#wtMUz-8#Bghj?E3`3@4>Nfie(yoxmDthxNXQ;(fnt-NE4n$Q1@>n$ z4=OY?H1ry6Vlp~XW`WEGM7XuH^GE$$$S~UXGaT-eGd=XF31(o7xJYep*ZOLx(%s$t z4-*rv(|2f?7i5YI!H;8<9`GU_=2@{E?fH~;eiI=aP%|WR1C4fLx4i+sw0Mb~zOR<1LbMy>R1H}eOhBH_?eP2fCLQBgTNJI#Mr$i^HI0&|z;GjB|G zQAvO9tTZoD{)v^v*ICk_Qi0&+>WH#>W2CS5f}!;~M0jl=)y`+>h$$dA`>j3V3oY$f z8^3BSqwVz1^Ply!T|Y`Gu1;p0GPAPI+6%L_b2|85s2n~52lq#2fFBf%X2!fcSPqi0 zr~LJ6gBDPJLiWRK)&~lp5X=ebC;U`F$QTIQvW5x1v~{$Wn~kysl`YcrqnT!e06lrU ziJ0HvGstbFDF6uiJzwt^sH4q3=34xQUi#rc>vh|~<(u&OMv+{vt`D>5Spml{O#XY_ zl}p^Apo^2O@P-C)Nk2lT{e)HftNO~b(^KXr66tJ%sRnuP*ap*X>taR_a@X$jb;1V4 znw{-(C_st-Yz)qLn#3`&O>oaiTw=Q5Z7_ixvba(5@PI2{WK|89i2xOVp4mEXVe z#Z%L2swQr}TQ&JfhjOs5I~q`~+=$o}l&iYP`7Aa=ef+cjoYXn6%E-vfM4LCiF6kGv zv9@mimNMw+F`W#+snTyDaC@d=v?{Cz?LTmC6mQG#sNy{1x1K?z0WB_|vf_U^kQ@Jx zg#T`P6(}?dsRuB*srR}2Z2VGu*Dkt6bt9Pa!}562 z>aj@`2cBaq^jnImWVBZFT$95Lcd+$iaklqhq>Y-+j8rp705VGy%Sg)R+0_^noUPL= z)u)pQY5$U2-_TGM@axK?(F4`r77ke*E}*u$dnf|v93G3-MA_J!$6LP?3C~Vog*`M& z>%$qZPj_QWN}h%j9&e22tJ0HRhXXPEan6_@0L{zGpKI`;mfgQ0c&{LjlWDDJzL!XG z%}xugMoF%ku!@Vrd)@aqsnpGo?x=TOwxmH(r2^#iV*MXITG_ZR9s!3Iw9TDCCFbg# zApbe{juIv|M-25nPSxhstBx^d{DWQdvw3*}X4-M9#01d{N(eL1px^7Su%ZOo^y9Gq zwO`0T{C}G?ma&cJjhBxBzs)Cr7=DW&I_)0;)|CH*$FS504iv1s3K(_giM6ciHN41nPS=Uqh$I?I?y$lOPx zzXaRet>o(F>gBQiR|#^ya)NJM6czQD{^{b{9Z2Cei~x2TDVm^7aDEK;Io{rhs7_)b z-5Bkd?)?zi&zZ`H`_QEtTWLF}lC0kI$sgj_AHh^lsaE{&TQS;cWyP8~%30`*XsJmAH(4Ky=p(&Ug?N*k#0u&6Mgi zX)nxD)MzyE$S}WY4N>$&nB+`jC49DzX|Yv&mNG$WO!013c!S0hJ%g%gxqqiMAC
w=2enCj@r@}6VGb3Omb9_T}kOi>aVBS)?c4S+`EIvEj`frDchwm~SoL3MRGeaQS>#ys zs_=7Qn@S0&>c@-qCFjAYedF@HNx~LbfL@_DTbX+D7vI5kw10oY)^sf?kUw2c%H!XM zt4gyuQUURwUFKI;A%IqWo5)uF)f|O4s?8uq6GRg>3`R~i*h&KZARP;fq8ZZp4UpZ- z5XmsJ^7TLA9cL#eJ%E;*D0JPLoCh~8)G?O7h}2nH&A|~YU7XOFH$0LD#~Dj7Q~g*rU+w18NM3iD#$@03Qz_zVdd zuVtngd3y_@XgO}bL|z_mO}b(wd|mr0E>DvZ^X&Iq7q`YN`AkTe-v!hHUs9+sr$0Xz z#WrZX&e^J_rdEU9L;*!b>9{e2u$s~C>+a6e<>a(;NphJlC}6#Rf6v~oRMDQcY>FKN~IA51DG75UyZVEAcT~`-FCn8sk;?#}P zc<9}|?UvDR`=LvF3o!FGuOu=$QHS|DU_ynR5B$A$D>S`Hw5PkfK(3DkU@ppJ?Homf z-nDeyZN$n>AvcX=$bBFl$$SRsBIRJg0J%`0GxjkjoK{ZLX4n+9CYnK56a)RhZ633D z7s*<)n3!7O5$#$>OrvxhqioT8n8C$`vrPI_6;voMzv5tS_TZ;h{U;#FtvGx5seBF8 z$6mniiq$*=W^IDt$(Lp5i25$8HdwDoo?cwuhWn)|QRk7dzw&pMN}`dFeR3pI(I0*% zsu`D~vWsa@-Y7;|)h*s56apq(A&X7iR)0GFQc>QQBNK<#5`6=M2ES{<>NfLsV7^p9 z^EcbPn2W{Jnz2w~i$>_=P%ZI-lw{l99)PO=jh0l6zl8m+f3G|=f(Ho3CjQg@zYiGW t-~Maj{oiKSBz3-}KNIj`Boc$e`{=xv1%4yK4a}xNYRcM52nFl6{{fSrZt(yB diff --git a/packages/html-reporter/src/chip.spec.tsx b/packages/html-reporter/src/chip.spec.tsx index 0329e49d45..3a0cfe908a 100644 --- a/packages/html-reporter/src/chip.spec.tsx +++ b/packages/html-reporter/src/chip.spec.tsx @@ -28,7 +28,6 @@ test('expand collapse', async ({ mount }) => { await expect(component.getByText('Chip body')).not.toBeVisible(); await component.getByText('Title').click(); await expect(component.getByText('Chip body')).toBeVisible(); - await expect(component).toHaveScreenshot(); }); test('render long title', async ({ mount }) => { @@ -38,7 +37,6 @@ test('render long title', async ({ mount }) => { ); await expect(component).toContainText('Extremely long title.'); await expect(component.getByText('Extremely long title.')).toHaveAttribute('title', title); - await expect(component).toHaveScreenshot(); }); test('setExpanded is called', async ({ mount }) => {