From 14a82928633c0b17abe38c24b87f735857795248 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 4 Nov 2020 11:00:25 -0800 Subject: [PATCH] feat(webkit): bump to 1378 (#4338) --- browsers.json | 2 +- test/page-close.spec.ts | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/browsers.json b/browsers.json index 84be337865..6abdae88ac 100644 --- a/browsers.json +++ b/browsers.json @@ -13,7 +13,7 @@ }, { "name": "webkit", - "revision": "1373", + "revision": "1378", "download": true } ] diff --git a/test/page-close.spec.ts b/test/page-close.spec.ts index 0fff268e0c..fb25bb9805 100644 --- a/test/page-close.spec.ts +++ b/test/page-close.spec.ts @@ -17,9 +17,7 @@ import { it, expect } from './fixtures'; -it('should close page with active dialog', (test, { browserName, platform }) => { - test.fixme(browserName === 'webkit' && platform === 'darwin', 'WebKit hangs on a Mac'); -}, async ({context}) => { +it('should close page with active dialog', async ({context}) => { const page = await context.newPage(); await page.setContent(``); page.click('button'); @@ -27,9 +25,7 @@ it('should close page with active dialog', (test, { browserName, platform }) => await page.close(); }); -it('should not accept after close', (test, { browserName, platform }) => { - test.fixme(browserName === 'webkit' && platform === 'darwin', 'WebKit hangs on a Mac'); -}, async ({page}) => { +it('should not accept after close', async ({page}) => { page.evaluate(() => alert()).catch(() => {}); const dialog = await page.waitForEvent('dialog'); await page.close();