microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-09-20 08:47:26 +03:00
Code Issues Projects Releases Wiki Activity

fix(webkit): fix non-mac screenshots w/ dsf (#1665)

Browse Source
This commit is contained in:
Pavel Feldman 2020-04-03 21:54:43 -07:00 committed by GitHub
parent a91304a37a
commit 17039f1649
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -10,7 +10,7 @@
"playwright": {
"chromium_revision": "754895",
"firefox_revision": "1069",
"webkit_revision": "1187"
"webkit_revision": "1188"
},
"scripts": {
"ctest": "cross-env BROWSER=chromium node test/test.js",

2
test/golden-utils.js
View File

@ -56,7 +56,7 @@ function compareImages(actualBuffer, expectedBuffer, mimeType) {
};
}
const diff = new PNG({width: expected.width, height: expected.height});
const count = pixelmatch(expected.data, actual.data, diff.data, expected.width, expected.height, {threshold: 0.15});
const count = pixelmatch(expected.data, actual.data, diff.data, expected.width, expected.height, {threshold: 0.2});
return count > 0 ? { diff: PNG.sync.write(diff) } : null;
}

4
test/screenshot.spec.js
View File

@ -217,7 +217,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO
expect(screenshot).toBeInstanceOf(Buffer);
}
});
it.fail(WEBKIT)('should work with device scale factor', async({browser, server}) => {
it('should work with device scale factor', async({browser, server}) => {
const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 });
const page = await context.newPage();
await page.goto(server.PREFIX + '/grid.html');
@ -394,7 +394,7 @@ module.exports.describe = function({testRunner, expect, product, playwright, FFO
expect(screenshot).toBeGolden('screenshot-element-mobile.png');
await context.close();
});
it.fail(WEBKIT && LINUX).skip(FFOX)('should work with device scale factor', async({browser, server}) => {
it.skip(FFOX)('should work with device scale factor', async({browser, server}) => {
const context = await browser.newContext({ viewport: { width: 320, height: 480 }, deviceScaleFactor: 2 });
const page = await context.newPage();
await page.goto(server.PREFIX + '/grid.html');