devops: add package-lock.json (#1859) (#1889)

We need to commit `package-lock.json` to repository to ensure
reproducible builds.

This also starts using [`npm ci`](https://docs.npmjs.com/cli/ci.html) to
install dependencies.

Drive-by: remove non-functioning `rebase` workflow.

.appveyor.yml

@@ -6,7 +6,7 @@ build: off
 
 install:
   - ps: Install-Product node $env:nodejs_version
-  - npm install
+  - npm ci
   - npm run ctest
   - npm run wtest
   - npm run ftest

.circleci/config.yml

@@ -10,7 +10,7 @@ jobs:
           key: dependency-cache-{{ checksum "package.json" }}
 
       - run:
-          command: npm install
+          command: npm ci
 
       - save_cache:
           key: dependency-cache-{{ checksum "package.json" }}

.github/workflows/infra.yml

@@ -25,5 +25,5 @@ jobs:
         sudo apt-get update
         sudo apt-get install libgbm-dev
         sudo apt-get install xvfb
-    - run: npm install
+    - run: npm ci
     - run: npm run lint

.github/workflows/rebase.yml

@@ -1,24 +0,0 @@
-on: 
-  issue_comment:
-    types: [created]
-name: Automatic Rebase
-jobs:
-  rebase:
-    name: Rebase
-    if: github.event.issue.pull_request != '' && contains(github.event.comment.body, '/rebase')
-    runs-on: ubuntu-latest
-    steps:
-    - uses: actions/checkout@master
-      with:
-        fetch-depth: 0
-    - name: Automatic Rebase
-      uses: cirrus-actions/rebase@1.2
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-  # https://github.community/t5/GitHub-Actions/Workflow-is-failing-if-no-job-can-be-ran-due-to-condition/m-p/38186#M3250
-  always_job:
-    name: Always run job
-    runs-on: ubuntu-latest
-    steps:
-      - name: Always run
-        run: echo "This job is used to prevent the workflow to fail when all other jobs are skipped."

.github/workflows/tests.yml

@@ -26,7 +26,7 @@ jobs:
     - name: install xvfb
       run: |
         sudo apt-get install xvfb
-    - run: npm install
+    - run: npm ci
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
     - run: xvfb-run --auto-servernum -- bash -c "npm run ccoverage 2>./chromium-linux-testrun.log"
@@ -55,7 +55,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run ctest 2>./chromium-mac-testrun.log
       env:
         DEBUG: "*"
@@ -82,7 +82,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run ctest 2>./chromium-win-testrun.log
       shell: bash
       env:
@@ -113,7 +113,7 @@ jobs:
     - name: install xvfb
       run: |
         sudo apt-get install xvfb
-    - run: npm install
+    - run: npm ci
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
     - run: xvfb-run --auto-servernum -- bash -c "npm run wcoverage 2>./webkit-linux-testrun.log"
@@ -142,7 +142,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run wtest 2>./webkit-mac-testrun.log
       env:
         DEBUG: "*,-pw:wrapped*"
@@ -169,7 +169,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run wtest 2>./webkit-win-testrun.log
       shell: bash
       env:
@@ -200,7 +200,7 @@ jobs:
     - name: install xvfb
       run: |
         sudo apt-get install xvfb
-    - run: npm install
+    - run: npm ci
     # XVFB-RUN merges both STDOUT and STDERR, whereas we need only STDERR
     # Wrap `npm run` in a subshell to redirect STDERR to file.
     - run: xvfb-run --auto-servernum -- bash -c "npm run fcoverage 2>./firefox-linux-testrun.log"
@@ -229,7 +229,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run ftest 2>./firefox-mac-testrun.log
       env:
         DEBUG: "*"
@@ -256,7 +256,7 @@ jobs:
       with:
         node-version: 10
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: npm run ftest 2>./firefox-win-testrun.log
       shell: bash
       env:
@@ -285,5 +285,5 @@ jobs:
         # we use in `installation-tests.sh`.
         node-version: 12
     - uses: microsoft/playwright-github-action@v1
-    - run: npm install
+    - run: npm ci
     - run: bash test/installation-tests/installation-tests.sh

.gitignore

@@ -9,7 +9,6 @@
 *.swp
 *.pyc
 .vscode
-package-lock.json
 yarn.lock
 /node6
 /src/generated/*

.travis.yml

@@ -26,6 +26,8 @@ addons:
     - xvfb
 notifications:
   email: false
+install:
+- npm ci
 cache:
   directories:
   - node_modules