From 1b441ef4f07fa27462011bff5bf4862e0063541d Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 17 Feb 2023 12:19:46 -0800 Subject: [PATCH] fix: stricter condition for Firefox codegen tests workaround (#20998) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes the following tests on WebKit @ Darwin: - library/inspector/cli-codegen-2.spec.ts:197:7 › cli codegen › should download files - library/inspector/cli-codegen-2.spec.ts:428:7 › cli codegen › should update hover model on action --- packages/playwright-core/src/server/injected/recorder.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/injected/recorder.ts b/packages/playwright-core/src/server/injected/recorder.ts index 9d1d323b7c..f7edf68113 100644 --- a/packages/playwright-core/src/server/injected/recorder.ts +++ b/packages/playwright-core/src/server/injected/recorder.ts @@ -239,7 +239,7 @@ export class Recorder { const activeElement = this._deepActiveElement(this.document); // Firefox dispatches "focus" event to body when clicking on a backgrounded headed browser window. // We'd like to ignore this stray event. - if (activeElement === this.document.body) + if (userGesture && activeElement === this.document.body) return; const result = activeElement ? generateSelector(this._injectedScript, activeElement, this._testIdAttributeName) : null; this._activeModel = result && result.selector ? result : null;