microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-09-20 08:47:26 +03:00
Code Issues Projects Releases Wiki Activity

tests(webkit): mark Page.navigate to invalid URL test as passing (#293)

Browse Source
This commit is contained in:
Yury Semikhatsky 2019-12-18 16:49:43 -07:00 committed by GitHub
parent ac2ea265fe
commit 1d4ebd37b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -10,7 +10,7 @@
"playwright": {
"chromium_revision": "724623",
"firefox_revision": "1008",
"webkit_revision": "1044"
"webkit_revision": "1046"
},
"scripts": {
"unit": "node test/test.js",

6
test/navigation.spec.js
View File

@ -141,10 +141,9 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
const response = await page.goto(server.EMPTY_PAGE, {waitUntil: 'networkidle2'});
expect(response.status()).toBe(200);
});
it.skip(WEBKIT)('should fail when navigating to bad url', async({page, server}) => {
it('should fail when navigating to bad url', async({page, server}) => {
let error = null;
await page.goto('asdfasdf').catch(e => error = e);
// FIXME: shows dialog in WebKit.
if (CHROME || WEBKIT)
expect(error.message).toContain('Cannot navigate to invalid URL');
else
@ -361,8 +360,7 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
process.removeListener('warning', warningHandler);
expect(warning).toBe(null);
});
it.skip(WEBKIT)('should not leak listeners during bad navigation', async({page, server}) => {
// FIXME: shows dialog in webkit.
it('should not leak listeners during bad navigation', async({page, server}) => {
let warning = null;
const warningHandler = w => warning = w;
process.on('warning', warningHandler);