microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-27 13:50:25 +03:00
Code Issues Projects Releases Wiki Activity

chore: allow sending trace URLs over stdin (#23288)

Browse Source
This commit is contained in:
Pavel Feldman 2023-05-25 15:38:47 -07:00 committed by GitHub
parent f879ac7e44
commit 1e95b6d906
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 33 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/cli/program.ts
View File

@ -275,6 +275,7 @@ program
.option('-b, --browser <browserType>', 'browser to use, one of cr, chromium, ff, firefox, wk, webkit', 'chromium')
.option('-h, --host <host>', 'Host to serve trace on', 'localhost')
.option('-p, --port <port>', 'Port to serve trace on', '9322')
.option('--stdin', 'Accept trace URLs over stdin to update the viewer')
.description('show trace viewer')
.action(function(traces, options) {
if (options.browser === 'cr')
@ -284,7 +285,7 @@ program
if (options.browser === 'wk')
options.browser = 'webkit';
showTraceViewer(traces, options.browser, { headless: false, host: options.host, port: +options.port }).catch(logErrorAndExit);
showTraceViewer(traces, options.browser, { headless: false, host: options.host, port: +options.port, isServer: !!options.stdin }).catch(logErrorAndExit);
}).addHelpText('afterAll', `
Examples:

29
packages/playwright-core/src/server/trace/viewer/traceViewer.ts
View File

@ -25,7 +25,7 @@ import { createPlaywright } from '../../playwright';
import { ProgressController } from '../../progress';
import type { Page } from '../../page';
type Options = { app?: string, headless?: boolean, host?: string, port?: number };
type Options = { app?: string, headless?: boolean, host?: string, port?: number, isServer?: boolean };
export async function showTraceViewer(traceUrls: string[], browserName: string, options?: Options): Promise<Page> {
const { headless = false, host, port, app } = options || {};
@ -115,9 +115,36 @@ export async function showTraceViewer(traceUrls: string[], browserName: string,
const searchQuery = params.length ? '?' + params.join('&') : '';
await page.mainFrame().goto(serverSideCallMetadata(), urlPrefix + `/trace/${app || 'index.html'}${searchQuery}`);
if (options?.isServer)
runServer(page);
return page;
}
function runServer(page: Page) {
let liveTraceTimer: NodeJS.Timeout | undefined;
const loadTrace = (url: string) => {
clearTimeout(liveTraceTimer);
page.mainFrame().evaluateExpression(`window.setTraceURL(${JSON.stringify(url)})`, false, undefined).catch(() => {});
};
const pollLoadTrace = (url: string) => {
loadTrace(url);
liveTraceTimer = setTimeout(() => {
pollLoadTrace(url);
}, 500);
};
process.stdin.on('data', data => {
const url = data.toString().trim();
if (url.endsWith('.json'))
pollLoadTrace(url);
else
loadTrace(url);
});
}
function traceDescriptor(traceName: string) {
const result: { entries: { name: string, path: string }[] } = {
entries: []

3
packages/trace-viewer/src/ui/workbenchLoader.tsx
View File

@ -78,6 +78,9 @@ export const WorkbenchLoader: React.FunctionComponent<{
}
}
(window as any).setTraceURL = (url: string) => {
setTraceURLs([url]);
};
// Don't re-use blob file URLs on page load (results in Fetch error)
if (!newTraceURLs.some(url => url.startsWith('blob:')))
setTraceURLs(newTraceURLs);