microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-11 12:33:45 +03:00
Code Issues Projects Releases Wiki Activity

feat(webkit): roll to r1830 (#22412)

Browse Source 
https://github.com/microsoft/playwright/issues/22411
Fixes https://github.com/microsoft/playwright/issues/21892
This commit is contained in:
Yury Semikhatsky 2023-04-14 13:32:50 -07:00 committed by GitHub
parent 7f856a65c4
commit 1fecc20238
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-core/browsers.json
View File

@ -33,7 +33,7 @@
},
{
"name": "webkit",
"revision": "1827",
"revision": "1830",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1446",

4
packages/playwright-core/src/server/webkit/protocol.d.ts vendored
View File

@ -7888,6 +7888,10 @@ the top of the viewport and Y increases as it proceeds towards the bottom of the
* Property symbol object, if the property is a symbol.
*/
symbol?: Runtime.RemoteObject;
/**
* True if the property is a private field.
*/
isPrivate?: boolean;
/**
* True if the property value came from a native getter.
*/

10
tests/library/browsercontext-pages.spec.ts
View File

@ -17,6 +17,7 @@
import { browserTest as it, expect } from '../config/browserTest';
import { attachFrame, chromiumVersionLessThan } from '../config/utils';
import os from 'os';
it('should not be visible in context.pages', async ({ contextFactory }) => {
const context = await contextFactory();
@ -94,8 +95,13 @@ it('should click the button with offset with page scale', async ({ browser, serv
const round = x => Math.round(x + 0.01);
let expected = { x: 28, y: 18 }; // 20;10 + 8px of border in each direction
if (browserName === 'webkit') {
// WebKit rounds down during css -> dip -> css conversion.
expected = { x: 26, y: 17 };
// WebKit for macOS 12 has different expectations starting r1829.
if (parseInt(os.release(), 10) < 21) {
// WebKit rounds down during css -> dip -> css conversion.
expected = { x: 26, y: 17 };
} else {
expected = { x: 29, y: 19 };
}
} else if (browserName === 'chromium' && headless) {
// Headless Chromium rounds down during css -> dip -> css conversion.
expected = { x: 27, y: 18 };

3
tests/library/download.spec.ts
View File

@ -705,9 +705,8 @@ it('should convert navigation to a resource with unsupported mime type into down
await page.close();
});
it('should download links with data url', async ({ page, isWindows, browserName }) => {
it('should download links with data url', async ({ page }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/21892' });
it.fixme(browserName === 'webkit' && isWindows);
await page.setContent('<a download="SomeFile.txt" href="data:text/plain;charset=utf8;,hello world">Download!</a>');
const donwloadPromise = page.waitForEvent('download');
await page.getByText('Download').click();

6
tests/library/video.spec.ts
View File

@ -674,9 +674,10 @@ it.describe('screencast', () => {
expect(files.length).toBe(1);
});
it('should capture full viewport', async ({ browserType, browserName, headless, isWindows, trace }, testInfo) => {
it('should capture full viewport', async ({ browserType, browserName, headless, isWindows, isLinux }, testInfo) => {
it.fixme(browserName === 'chromium' && !headless, 'The square is not on the video');
it.fixme(browserName === 'firefox' && isWindows, 'https://github.com/microsoft/playwright/issues/14405');
it.fixme(browserName === 'webkit' && isLinux && !headless, 'https://github.com/microsoft/playwright/issues/22411');
const size = { width: 600, height: 400 };
const browser = await browserType.launch();
@ -708,9 +709,10 @@ it.describe('screencast', () => {
expectAll(pixels, almostRed);
});
it('should capture full viewport on hidpi', async ({ browserType, browserName, headless, isWindows, trace }, testInfo) => {
it('should capture full viewport on hidpi', async ({ browserType, browserName, headless, isWindows, isLinux }, testInfo) => {
it.fixme(browserName === 'chromium' && !headless, 'The square is not on the video');
it.fixme(browserName === 'firefox' && isWindows, 'https://github.com/microsoft/playwright/issues/14405');
it.fixme(browserName === 'webkit' && isLinux && !headless, 'https://github.com/microsoft/playwright/issues/22411');
const size = { width: 600, height: 400 };
const browser = await browserType.launch();