microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 21:53:35 +03:00
Code Issues Projects Releases Wiki Activity

devops: do not check for logs existance when building browsers (#5367)

Browse Source 
In our *old world*, browser buildbots were polling repo and were
trying to rebuild browsers every 5 minutes. They relied on the presence
of either build or build log on the CDN to avoid continiously
re-building.

In the new world, we trigger builds only when we change the
`BUILD_NUMBER` files, so there's no polling any more.

This patch removes the check for log presence so that those builds that
were failing due to misconfiguration (e.g. Visual Studio license
required updated) could be restarted just from the GitHub UI.
This commit is contained in:
Andrey Lushnikov 2021-02-08 16:19:37 -08:00 committed by GitHub
parent d49a1d8174
commit 21c24c2357
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser_patches/checkout_build_archive_upload.sh
View File

@ -233,11 +233,7 @@ if ! [[ ($2 == '-f') || ($2 == '--force') ]]; then
if ./upload.sh "${BUILD_BLOB_PATH}" --check; then if ./upload.sh "${BUILD_BLOB_PATH}" --check; then
echo "Build is already uploaded - no changes." echo "Build is already uploaded - no changes."
exit 0 exit 0
elif ./upload.sh "${LOG_BLOB_PATH}" --check; then
echo "This build has already been attempted - skip building."
exit 0
fi fi
echo "Build is missing and has not been attempted - rebuilding"
else else
echo "Force-rebuilding the build." echo "Force-rebuilding the build."
fi fi