microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-11 12:33:45 +03:00
Code Issues Projects Releases Wiki Activity

fix: provisional fix for Trace Viewer source 404 (#29192)

Browse Source 
Motivation: Sometimes the files are not available anymore on the Service
Worker side. The Trace Viewer frontend then falls back to `file?path=`
and uses its response, no matter what the response status is.

This patch checks for the response status code before using its
response.

e.g. https://github.com/microsoft/playwright-dotnet/issues/2775 after
some time / and some other reports.

---------

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
This commit is contained in:
Max Schmitt 2024-01-27 14:05:15 +01:00 committed by GitHub
parent 5ee7179b13
commit 36ebdfb441
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/trace-viewer/src/ui/sourceTab.tsx
View File

@ -67,7 +67,10 @@ export const SourceTab: React.FunctionComponent<{
let response = await fetch(`sha1/src@${sha1}.txt`); let response = await fetch(`sha1/src@${sha1}.txt`);
if (response.status === 404) if (response.status === 404)
response = await fetch(`file?path=${encodeURIComponent(file)}`); response = await fetch(`file?path=${encodeURIComponent(file)}`);
source.content = await response.text(); if (response.status >= 400)
source.content = `<Unable to read "${file}">`;
else
source.content = await response.text();
} catch { } catch {
source.content = `<Unable to read "${file}">`; source.content = `<Unable to read "${file}">`;
} }