From 3e491114f20a00bc86d736569b090eec902bb8cb Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Wed, 4 Aug 2021 23:36:27 +0200
Subject: [PATCH] test: fix some failing locators tests (#7989)

---
 src/utils/dependencies.ts                         |   1 +
 tests/page/locator-convenience.spec.ts            |   4 ++--
 tests/page/locator-misc-2.spec.ts                 |   3 ++-
 .../screenshot-element-bounding-box-firefox.png   | Bin 0 -> 311 bytes
 .../screenshot-element-bounding-box-webkit.png    | Bin 0 -> 633 bytes
 5 files changed, 5 insertions(+), 3 deletions(-)
 create mode 100644 tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-firefox.png
 create mode 100644 tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-webkit.png

diff --git a/src/utils/dependencies.ts b/src/utils/dependencies.ts
index 2bfd2cbf8e..c5052fb251 100644
--- a/src/utils/dependencies.ts
+++ b/src/utils/dependencies.ts
@@ -393,6 +393,7 @@ const LIBRARY_TO_PACKAGE_NAME_UBUNTU_20_04: { [s: string]: string} = {
   'libdrm.so.2': 'libdrm2',
   'libEGL.so.1': 'libegl1',
   'libenchant.so.1': 'libenchant1c2a',
+  'libevdev.so.2': 'libevdev2',
   'libepoxy.so.0': 'libepoxy0',
   'libfontconfig.so.1': 'libfontconfig1',
   'libfreetype.so.6': 'libfreetype6',
diff --git a/tests/page/locator-convenience.spec.ts b/tests/page/locator-convenience.spec.ts
index e9f146268c..f06769383f 100644
--- a/tests/page/locator-convenience.spec.ts
+++ b/tests/page/locator-convenience.spec.ts
@@ -103,9 +103,9 @@ it('textContent should be atomic', async ({ playwright, page }) => {
       return result;
     }
   });
-  await playwright.selectors.register('textContent', createDummySelector);
+  await playwright.selectors.register('textContentFromLocators', createDummySelector);
   await page.setContent(`<div>Hello</div>`);
-  const tc = await page.textContent('textContent=div');
+  const tc = await page.textContent('textContentFromLocators=div');
   expect(tc).toBe('Hello');
   expect(await page.evaluate(() => document.querySelector('div').textContent)).toBe('modified');
 });
diff --git a/tests/page/locator-misc-2.spec.ts b/tests/page/locator-misc-2.spec.ts
index 81da5b67d7..b20017f70a 100644
--- a/tests/page/locator-misc-2.spec.ts
+++ b/tests/page/locator-misc-2.spec.ts
@@ -72,8 +72,9 @@ it('should take screenshot', async ({ page, server, browserName, headless, isAnd
   expect(screenshot).toMatchSnapshot('screenshot-element-bounding-box.png');
 });
 
-it('should return bounding box', async ({ page, server, browserName, headless }) => {
+it('should return bounding box', async ({ page, server, browserName, headless, isAndroid }) => {
   it.fail(browserName === 'firefox' && !headless);
+  it.skip(isAndroid);
 
   await page.setViewportSize({ width: 500, height: 500 });
   await page.goto(server.PREFIX + '/grid.html');
diff --git a/tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-firefox.png b/tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-firefox.png
new file mode 100644
index 0000000000000000000000000000000000000000..9e208f86d8f7690a79f6bf31ccdd2032512693a3
GIT binary patch
literal 311
zcmeAS@N?(olHy`uVBq!ia0vp^Mj*_=1|;R|J2nETf1WOmAsLNtuPUx<F%W5exS8=y
zEQ63|Qxfl*rUU^G4($UE1J*2H5}F`TW{_o8GOwy*W=~F$_qrdxzMr@H>dz^zaVj`B
z@qPFONtbB0i_;vpqzdFBF)Le3V%-^74w(2>&P%VDpyJ8VkbApmUV0Y?W5NCJ1q!#f
z2{KGi{dq{#RgmwA1z*>R>s67{5*_PQl^!~8(otrJyDqAya=w`9fkofFZy)$NAJ1U0
z@SS}9@F%XH^A%t3s&cJp?ci9f@rmyPmt@<+eZ9*vBSNpn-v9p4;nl8vit}0j|7H8R
wg(pd%`Ne64TSgt*coyk4XF!<q*ejjtXU$LH$a>TA6BrT<p00i_>zopr0K4LVFaQ7m

literal 0
HcmV?d00001

diff --git a/tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-webkit.png b/tests/page/locator-misc-2.spec.ts-snapshots/screenshot-element-bounding-box-webkit.png
new file mode 100644
index 0000000000000000000000000000000000000000..dea5418facdfcdec0195e5c5bc5f81635958f76a
GIT binary patch
literal 633
zcmeAS@N?(olHy`uVBq!ia0vp^Mj*_=1|;R|J2nC-#^NA%Cx&(BWL^R}E~ycoX}-P;
zT0k}j17mw80}DtA5K93u0|WB{Mh0de%?J`(zyy~yTEL88gA|sYUcVZs?6IedV@L*T
za?H-6r}b@#3=s}>9G64nF2zNb{?%i?JmDMTq{r^IO(GJ_O_oy1%}P=eWDKR0JsJ%)
zW-K-|(pbcJQgE>$4rwP1DXr;i6BDi&GbaC?q0+W@y`8`%r-?ScNiMn;lNK&s+`Mql
zo;iu<=2-Id%h@Is6c#4l`1HZjweRTinXlw-{&^sI`0efOlGoP9pT8g|dul>X+JO)M
zF37QkhK9DyG){k1%<Wnf@|{CnUA?)Xfx)?9lTO#+H*ekq{J8Qg;I6XXqoxNE4&^Uy
zZOy*ey5iLGUG5upp0iNweR#N?pU2hJ^~REwN^Zsd5zC$$%&{)-TeyG!{DXll{aSs;
z(l{z&xM#DN9(l5dSyIlv?u<e1Et57MY2z%3&dWTrDp^9>8yHr6aXSCQBG$Q)#n(nD
z<N2WjM~@!;@b!oy*BrN5VXLZ_6yKIBIL2nFTz^if?fw1zhhtT=v`$@+5@dNEJlV0d
zzagtoVunekP!H#_+L{^(iHs+LZWl8CyihRns^HgYfA*DQ?;i74f>o_18^84&<JhR^
zs$aU;&}sbywQKV(N+_Bwd9gIl#O;OXr6aeDrIe4fiR``7dyHeR)2xVUx8#-^6BbRk
hDwr?3<zD6rW`^WVF>0?LN`R6DgQu&X%Q~loCIB16^HTr-

literal 0
HcmV?d00001