From 3e78426accf61fd8bd4c3294e71e58f66b42fab1 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Fri, 15 Mar 2024 16:25:36 +0100
Subject: [PATCH] fix(trace-viewer): report upload error as aria-role=alert
 (#29956)

Turns out NVDA and Narrator work differently. This is a follow-up to
https://github.com/microsoft/playwright/pull/29838 which was not working
in NVDA before - looks like a NVDA bug. Using alert instead.

Relates
https://github.com/microsoft/playwright/issues/29095#issuecomment-1999332067
---
 packages/trace-viewer/src/ui/workbenchLoader.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/trace-viewer/src/ui/workbenchLoader.tsx b/packages/trace-viewer/src/ui/workbenchLoader.tsx
index 71e0165332..bc87a514db 100644
--- a/packages/trace-viewer/src/ui/workbenchLoader.tsx
+++ b/packages/trace-viewer/src/ui/workbenchLoader.tsx
@@ -162,7 +162,7 @@ export const WorkbenchLoader: React.FunctionComponent<{
       </div>
     </div>}
     {showFileUploadDropArea && <div className='drop-target'>
-      <div className='processing-error' aria-live='assertive'>{processingErrorMessage}</div>
+      <div className='processing-error' role='alert'>{processingErrorMessage}</div>
       <div className='title' role='heading' aria-level={1}>Drop Playwright Trace to load</div>
       <div>or</div>
       <button onClick={() => {