feat: bump webkit version to include screencast fixes (#4200)

This commit is contained in:
Yury Semikhatsky 2020-10-23 10:33:58 -07:00 committed by GitHub
parent c4fbc6436a
commit 50a6ba7fdc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions

View File

@ -13,7 +13,7 @@
},
{
"name": "webkit",
"revision": "1363",
"revision": "1364",
"download": true
}
]

View File

@ -40,7 +40,9 @@ export class VideoPlayer {
constructor(fileName: string) {
this.fileName = fileName;
this.output = spawnSync(ffmpeg, ['-i', this.fileName, `${this.fileName}-%03d.png`]).stderr.toString();
// Force output frame rate to 25 fps as otherwise it would produce one image per timebase unit
// which is 1 / (25 * 1000).
this.output = spawnSync(ffmpeg, ['-i', this.fileName, '-r', '25', `${this.fileName}-%03d.png`]).stderr.toString();
const lines = this.output.split('\n');
let framesLine = lines.find(l => l.startsWith('frame='))!;
@ -123,7 +125,7 @@ function expectAll(pixels: Buffer, rgbaPredicate) {
checkPixel(i);
} catch (e) {
// Log pixel values on failure.
e.message += `\n\nActual pixels=[${pixels}]`;
e.message += `\n\nActual pixels=[${pixels.join(',')}]`;
throw e;
}
}