From 513899a3b9a32e93afa65f140c7eeb888681bd99 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 16 Jul 2020 12:21:36 -0700 Subject: [PATCH] test: add a test for arbitrary options (#2977) We should be able to accept unexpected properties in options objects. --- test/launcher.spec.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/launcher.spec.js b/test/launcher.spec.js index be52970f12..47cd56230f 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -18,7 +18,7 @@ const path = require('path'); const fs = require('fs'); const utils = require('./utils'); -const {FFOX, CHROMIUM, WEBKIT, WIN, USES_HOOKS} = utils.testOptions(browserType); +const {FFOX, CHROMIUM, WEBKIT, WIN, USES_HOOKS, CHANNEL} = utils.testOptions(browserType); describe('Playwright', function() { describe('browserType.launch', function() { @@ -75,6 +75,10 @@ describe('Playwright', function() { const error = await browserType.launch(options).catch(e => e); expect(error.message).toContain(''); }); + it.slow().skip(CHANNEL)('should accept objects as options', async({browserType, defaultBrowserOptions}) => { + const browser = await browserType.launch({ ...defaultBrowserOptions, process }); + await browser.close(); + }); }); describe('browserType.launchServer', function() {