microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-05 19:04:43 +03:00
Code Issues Projects Releases Wiki Activity

chore: do not always return 200 on component testing network requests (#23408)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/23364

See here about their AppTypes:
https://vitejs.dev/config/shared-options.html#apptype
This commit is contained in:
Max Schmitt 2023-06-01 01:33:48 +02:00 committed by GitHub
parent 92d650c317
commit 5701ff1e9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-ct-core/src/vitePlugin.ts
View File

@ -109,6 +109,8 @@ export function createPlugin(
viteConfig.root = rootDir;
viteConfig.preview = { port, ...viteConfig.preview };
// Vite preview server will otherwise always return the index.html with 200.
viteConfig.appType = viteConfig.appType || 'custom';
// React heuristic. If we see a component in a file with .js extension,
// consider it a potential JSX-in-JS scenario and enable JSX loader for all

13
tests/components/ct-react17/tests/render.spec.tsx
View File

@ -59,3 +59,16 @@ testWithServer(
await expect.soft(component).toHaveText('intercepted');
}
);
test('should return 404 if server does not handle the request', async ({ page }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/23364' });
const helloPromise = page.waitForResponse('/hello');
const statusCode = await page.evaluate(async () => {
const response = await fetch('/hello');
return response.status;
});
expect(statusCode).toBe(404);
const response = await helloPromise;
expect(response.status()).toBe(404);
expect(response.statusText()).toBe('Not Found');
});