From 576b3406e3bbf0957e87e8b0af6c884dd0db90da Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Fri, 15 Dec 2023 17:39:31 -0800 Subject: [PATCH] test: tree gardening (#28676) Looks like massaging the signals test in https://github.com/microsoft/playwright/commit/8ab0660d1b3380e9963e2cd85a8a7cfa6fc48f29#diff-f9d332d27364a8a58e52f5d7ffc180df7581589565b62186757b21839aabf889 didn't make it fully green. As of today it fails on Darwin 13 which is version 22, so we should not run into the first if. --- tests/library/signals.spec.ts | 2 +- tests/page/page-screenshot.spec.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/library/signals.spec.ts b/tests/library/signals.spec.ts index c41df7b1e7..6ae54cfd3c 100644 --- a/tests/library/signals.spec.ts +++ b/tests/library/signals.spec.ts @@ -63,7 +63,7 @@ test.describe('signals', () => { const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); const pid = await remoteServer.out('pid'); process.kill(-pid, 'SIGKILL'); - if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22 && os.arch() === 'arm64') { + if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) > 22 && os.arch() === 'arm64') { // WebKit on newer macOS exits differently. expect(await remoteServer.out('exitCode')).toBe('137'); expect(await remoteServer.out('signal')).toBe('null'); diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts index fd7b8e91a4..47188f52a4 100644 --- a/tests/page/page-screenshot.spec.ts +++ b/tests/page/page-screenshot.spec.ts @@ -857,8 +857,9 @@ it.describe('page screenshot animations', () => { ]); }); - it('should wait for fonts to load', async ({ page, server, isWindows, browserName, isLinux }) => { + it('should wait for fonts to load', async ({ page, server, isWindows, isAndroid }) => { it.fixme(isWindows, 'This requires a windows-specific test expectations. https://github.com/microsoft/playwright/issues/12707'); + it.skip(isAndroid, 'Different viewport'); await page.setViewportSize({ width: 500, height: 500 }); const fontRequestPromise = new Promise(resolve => { // Stall font loading.