microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-11 04:30:17 +03:00
Code Issues Projects Releases Wiki Activity

chore: fix language binding based install message (#18480)

Browse Source
This commit is contained in:
Max Schmitt 2022-11-01 13:46:17 -07:00 committed by GitHub
parent 4d53fd9c63
commit 57c2ed91d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/inProcessFactory.ts
View File

@ -19,9 +19,10 @@ import { createPlaywright, DispatcherConnection, RootDispatcher, PlaywrightDispa
import { Connection } from './client/connection';
import { BrowserServerLauncherImpl } from './browserServerImpl';
import { AndroidServerLauncherImpl } from './androidServerImpl';
import type { Language } from './server/isomorphic/locatorGenerators';
export function createInProcessPlaywright(): PlaywrightAPI {
const playwright = createPlaywright('javascript');
const playwright = createPlaywright((process.env.PW_LANG_NAME as Language | undefined) || 'javascript');
const clientConnection = new Connection();
const dispatcherConnection = new DispatcherConnection(true /* local */);

39
tests/installation/playwright-cli-install-should-work-with-languages.spec.ts Executable file
View File

@ -0,0 +1,39 @@
/**
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { test, expect } from './npmTest';
test('codegen should print the right install command without browsers', async ({ exec }) => {
await exec('npm i --foreground-scripts playwright', { env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1' } });
const pwLangName2InstallCommand = {
'java': 'mvn exec:java -e -Dexec.mainClass=com.microsoft.playwright.CLI -Dexec.args="install"',
'python': 'playwright install',
'csharp': 'pwsh bin/Debug/netX/playwright.ps1 install',
'': 'npx playwright install',
};
for (const [langName, installCommand] of Object.entries(pwLangName2InstallCommand)) {
await test.step(`codegen should work for ${langName}`, async () => {
const result = await exec('npx playwright codegen', {
expectToExitWithError: true,
env: {
PW_LANG_NAME: langName,
}
});
expect(result).toContain(installCommand);
});
}
});