microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-27 05:46:28 +03:00
Code Issues Projects Releases Wiki Activity

fix: use logger in default context with connectOverCDP (#28838)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/28813
This commit is contained in:
Max Schmitt 2024-01-03 19:49:47 +01:00 committed by GitHub
parent abc746bd7a
commit 58fa4fce74
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-core/src/client/browserType.ts
View File

@ -216,7 +216,7 @@ export class BrowserType extends ChannelOwner<channels.BrowserTypeChannel> imple
const browser = Browser.from(result.browser);
this._didLaunchBrowser(browser, {}, params.logger);
if (result.defaultContext)
await this._didCreateContext(BrowserContext.from(result.defaultContext), {}, {}, undefined);
await this._didCreateContext(BrowserContext.from(result.defaultContext), {}, {}, params.logger);
return browser;
}

27
tests/library/chromium/connect-over-cdp.spec.ts
View File

@ -40,6 +40,33 @@ test('should connect to an existing cdp session', async ({ browserType, mode },
}
});
test('should use logger in default context', async ({ browserType }, testInfo) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/28813' });
const port = 9339 + testInfo.workerIndex;
const browserServer = await browserType.launch({
args: ['--remote-debugging-port=' + port]
});
try {
const log = [];
const browser = await browserType.connectOverCDP({
endpointURL: `http://127.0.0.1:${port}/`,
logger: {
log: (name, severity, message) => log.push({ name, severity, message }),
isEnabled: (name, severity) => severity !== 'verbose'
}
});
const page = await browser.contexts()[0].newPage();
await page.setContent('<button>Button</button>');
await page.click('button');
await browser.close();
expect(log.length > 0).toBeTruthy();
expect(log.filter(item => item.message.includes('page.setContent')).length > 0).toBeTruthy();
expect(log.filter(item => item.message.includes('page.click')).length > 0).toBeTruthy();
} finally {
await browserServer.close();
}
});
test('should cleanup artifacts dir after connectOverCDP disconnects due to ws close', async ({ browserType, toImpl, mode }, testInfo) => {
const port = 9339 + testInfo.workerIndex;
const browserServer = await browserType.launch({