microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-27 13:50:25 +03:00
Code Issues Projects Releases Wiki Activity

feat(fetch): browser proxy credentials (#8760)

Browse Source
This commit is contained in:
Yury Semikhatsky 2021-09-07 17:42:31 -07:00 committed by GitHub
parent afe92a6fcf
commit 6263361284
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/server/fetch.ts
View File

@ -40,12 +40,13 @@ export async function playwrightFetch(context: BrowserContext, params: types.Fet
}
const method = params.method?.toUpperCase() || 'GET';
const proxy = context._options.proxy || context._browser.options.proxy;
let agent;
if (context._options.proxy) {
if (proxy) {
// TODO: support bypass proxy
const proxyOpts = url.parse(context._options.proxy.server);
if (context._options.proxy.username)
proxyOpts.auth = `${context._options.proxy.username}:${context._options.proxy.password || ''}`;
const proxyOpts = url.parse(proxy.server);
if (proxy.username)
proxyOpts.auth = `${proxy.username}:${proxy.password || ''}`;
agent = new HttpsProxyAgent(proxyOpts);
}

20
tests/browsercontext-fetch.spec.ts
View File

@ -282,6 +282,26 @@ it('should work with context level proxy', async ({browserOptions, browserType,
}
});
it('should pass proxy credentials', async ({browserType, browserOptions, server, proxyServer}) => {
proxyServer.forwardTo(server.PORT);
let auth;
proxyServer.setAuthHandler(req => {
auth = req.headers['proxy-authorization'];
return !!auth;
});
const browser = await browserType.launch({
...browserOptions,
proxy: { server: `localhost:${proxyServer.PORT}`, username: 'user', password: 'secret' }
});
const context = await browser.newContext();
// @ts-expect-error
const response = await context._fetch('http://non-existent.com/simple.json');
expect(proxyServer.connectHosts).toContain('non-existent.com:80');
expect(auth).toBe('Basic ' + Buffer.from('user:secret').toString('base64'));
expect(await response.json()).toEqual({foo: 'bar'});
await browser.close();
});
it('should work with http credentials', async ({context, server}) => {
server.setAuth('/empty.html', 'user', 'pass');