test: rearrange / uncomment more tests

This commit is contained in:
Pavel Feldman 2019-12-11 22:52:14 -08:00
parent 995300b778
commit 66e93ce2c0
3 changed files with 13 additions and 11 deletions

View File

@ -56,14 +56,4 @@ module.exports.addTests = function({testRunner, expect, headless, playwright, FF
remoteBrowser.disconnect();
});
});
describe.skip(WEBKIT || FFOX)('Browser.isConnected', () => {
it('should set the browser connected state', async({browser}) => {
const browserWSEndpoint = browser.chromium.wsEndpoint();
const newBrowser = await playwright.connect({browserWSEndpoint});
expect(newBrowser.isConnected()).toBe(true);
newBrowser.disconnect();
expect(newBrowser.isConnected()).toBe(false);
});
});
};

View File

@ -145,4 +145,16 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions, p
});
});
describe('Browser.isConnected', () => {
it('should set the browser connected state', async () => {
const browser = await playwright.launch(defaultBrowserOptions);
const browserWSEndpoint = browser.chromium.wsEndpoint();
const newBrowser = await playwright.connect({browserWSEndpoint});
expect(newBrowser.isConnected()).toBe(true);
newBrowser.disconnect();
expect(newBrowser.isConnected()).toBe(false);
await browser.close();
});
});
};

View File

@ -1037,7 +1037,7 @@ module.exports.addTests = function({testRunner, expect, headless, playwright, FF
expect(error.message).toContain('Indices must be numbers');
});
// @see https://github.com/GoogleChrome/puppeteer/issues/3327
it.skip(FFOX || WEBKIT)('should work when re-defining top-level Event class', async({page, server}) => {
it.skip(FFOX)('should work when re-defining top-level Event class', async({page, server}) => {
await page.goto(server.PREFIX + '/input/select.html');
await page.evaluate(() => window.Event = null);
await page.select('select', 'blue');