microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-05 19:04:43 +03:00
Code Issues Projects Releases Wiki Activity

chore: show channel name in trace viewer metadata (#26987)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/26986
This commit is contained in:
Max Schmitt 2023-09-11 23:06:56 +02:00 committed by GitHub
parent 5811d65b9d
commit 6bbc09c96c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/playwright-core/src/server/trace/recorder/tracing.ts
View File

@ -109,6 +109,7 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps
this._snapshotter = new Snapshotter(context, this);
assert(tracesDir, 'tracesDir must be specified for BrowserContext');
this._contextCreatedEvent.browserName = context._browser.options.name;
this._contextCreatedEvent.channel = context._browser.options.channel;
this._contextCreatedEvent.options = context._options;
}
}

1
packages/trace-viewer/src/entries.ts
View File

@ -24,6 +24,7 @@ export type ContextEntry = {
startTime: number;
endTime: number;
browserName: string;
channel?: string;
platform?: string;
wallTime?: number;
sdkLanguage?: Language;

1
packages/trace-viewer/src/traceModel.ts
View File

@ -156,6 +156,7 @@ export class TraceModel {
this._version = event.version;
contextEntry.isPrimary = true;
contextEntry.browserName = event.browserName;
contextEntry.channel = event.channel;
contextEntry.title = event.title;
contextEntry.platform = event.platform;
contextEntry.wallTime = event.wallTime;

1
packages/trace-viewer/src/ui/metadataView.tsx
View File

@ -30,6 +30,7 @@ export const MetadataView: React.FunctionComponent<{
<div className='call-line'>duration:<span className='call-value number' title={msToString(model.endTime - model.startTime)}>{msToString(model.endTime - model.startTime)}</span></div>
<div className='call-section'>Browser</div>
<div className='call-line'>engine:<span className='call-value string' title={model.browserName}>{model.browserName}</span></div>
{model.channel && <div className='call-line'>channel:<span className='call-value string' title={model.channel}>{model.channel}</span></div>}
{model.platform && <div className='call-line'>platform:<span className='call-value string' title={model.platform}>{model.platform}</span></div>}
{model.options.userAgent && <div className='call-line'>user agent:<span className='call-value datetime' title={model.options.userAgent}>{model.options.userAgent}</span></div>}
<div className='call-section'>Viewport</div>

2
packages/trace-viewer/src/ui/modelUtil.ts
View File

@ -51,6 +51,7 @@ export class MultiTraceModel {
readonly startTime: number;
readonly endTime: number;
readonly browserName: string;
readonly channel?: string;
readonly platform?: string;
readonly wallTime?: number;
readonly title?: string;
@ -72,6 +73,7 @@ export class MultiTraceModel {
this.browserName = primaryContext?.browserName || '';
this.sdkLanguage = primaryContext?.sdkLanguage;
this.channel = primaryContext?.channel;
this.testIdAttributeName = primaryContext?.testIdAttributeName;
this.platform = primaryContext?.platform || '';
this.title = primaryContext?.title || '';

1
packages/trace/src/trace.ts
View File

@ -34,6 +34,7 @@ export type ContextCreatedTraceEvent = {
version: number,
type: 'context-options',
browserName: string,
channel?: string,
platform: string,
wallTime: number,
title?: string,