microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-11-28 17:44:33 +03:00
Code Issues Projects Releases Wiki Activity

chore: unflake 'should record' (#32880)

Browse Source
This commit is contained in:
Max Schmitt 2024-09-30 20:32:04 +02:00 committed by GitHub
parent 6f99d48a12
commit 6f16b6cc08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-core/src/server/recorder/recorderCollection.ts
View File

@ -126,6 +126,8 @@ export class RecorderCollection extends EventEmitter {
} }
private _fireChange() { private _fireChange() {
if (!this._enabled)
return;
this.emit('change', collapseActions(this._actions)); this.emit('change', collapseActions(this._actions));
} }
} }

2
tests/library/debug-controller.spec.ts
View File

@ -188,9 +188,9 @@ test('test', async ({ page }) => {
await page.getByRole('button', { name: 'Submit' }).click(); await page.getByRole('button', { name: 'Submit' }).click();
});` });`
}); });
const length = events.length;
// No events after mode disabled // No events after mode disabled
await backend.setRecorderMode({ mode: 'none' }); await backend.setRecorderMode({ mode: 'none' });
const length = events.length;
await page.getByRole('button').click(); await page.getByRole('button').click();
expect(events).toHaveLength(length); expect(events).toHaveLength(length);
}); });