microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-11-30 23:45:33 +03:00
Code Issues Projects Releases Wiki Activity

fix(ui-mode): use onChange instead of onClick for <input type='checkbox' (#33636)

Browse Source
This commit is contained in:
Max Schmitt 2024-11-18 10:21:28 +01:00 committed by GitHub
parent 82c77a5e9e
commit 6fce5620e0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/trace-viewer/src/ui/settingsView.tsx
View File

@ -30,7 +30,7 @@ export const SettingsView: React.FunctionComponent<{
{settings.map(({ value, set, title }) => {
return <div key={title} className='setting'>
<label>
<input type='checkbox' checked={value} onClick={() => set(!value)}/>
<input type='checkbox' checked={value} onChange={() => set(!value)}/>
{title}
</label>
</div>;

4
packages/trace-viewer/src/ui/uiModeFiltersView.tsx
View File

@ -62,7 +62,7 @@ export const FiltersView: React.FC<{
{[...statusFilters.entries()].map(([status, value]) => {
return <div className='filter-entry' key={status} role='listitem'>
<label>
<input type='checkbox' checked={value} onClick={() => {
<input type='checkbox' checked={value} onChange={() => {
const copy = new Map(statusFilters);
copy.set(status, !copy.get(status));
setStatusFilters(copy);
@ -76,7 +76,7 @@ export const FiltersView: React.FC<{
{[...projectFilters.entries()].map(([projectName, value]) => {
return <div className='filter-entry' key={projectName} role='listitem'>
<label>
<input type='checkbox' checked={value} onClick={() => {
<input type='checkbox' checked={value} onChange={() => {
const copy = new Map(projectFilters);
copy.set(projectName, !copy.get(projectName));
setProjectFilters(copy);