microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 21:53:35 +03:00
Code Issues Projects Releases Wiki Activity

fix(trace): copy cached resources on write (optimization) (#7372)

Browse Source
This commit is contained in:
Pavel Feldman 2021-06-28 22:01:08 -07:00 committed by GitHub
parent 1660334357
commit 7062278265
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/snapshot/snapshotStorage.ts
View File

@ -33,6 +33,7 @@ export abstract class BaseSnapshotStorage extends EventEmitter implements Snapsh
renderer: SnapshotRenderer[]
}>();
protected _contextResources: ContextResources = new Map();
private _contextResourcesCopyOnWrite: ContextResources | null = null;
clear() {
this._resources = [];
@ -42,6 +43,7 @@ export abstract class BaseSnapshotStorage extends EventEmitter implements Snapsh
}
addResource(resource: ResourceSnapshot): void {
this._contextResourcesCopyOnWrite = null;
this._resourceMap.set(resource.resourceId, resource);
this._resources.push(resource);
let resources = this._contextResources.get(resource.url);
@ -64,7 +66,9 @@ export abstract class BaseSnapshotStorage extends EventEmitter implements Snapsh
this._frameSnapshots.set(snapshot.pageId, frameSnapshots);
}
frameSnapshots.raw.push(snapshot);
const renderer = new SnapshotRenderer(new Map(this._contextResources), frameSnapshots.raw, frameSnapshots.raw.length - 1);
if (!this._contextResourcesCopyOnWrite)
this._contextResourcesCopyOnWrite = new Map(this._contextResources);
const renderer = new SnapshotRenderer(this._contextResourcesCopyOnWrite, frameSnapshots.raw, frameSnapshots.raw.length - 1);
frameSnapshots.renderer.push(renderer);
this.emit('snapshot', renderer);
}