From 7671e8e8be8846ced6423b67bed1354b80719d09 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 2 Sep 2020 18:02:11 -0700 Subject: [PATCH] devops: remove warnings when running under root without sandbox (#3749) As discussed offline, our testing scenarios assume running trusted web content - so this warning is just a noise for this usecases. When it comes to dealing with untrusted web content though, automation authors need to make sure to not launch browsers under root in the first place. --- src/server/chromium/chromium.ts | 4 +--- src/server/electron/electron.ts | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/server/chromium/chromium.ts b/src/server/chromium/chromium.ts index 044235e4d4..ca0e688d38 100644 --- a/src/server/chromium/chromium.ts +++ b/src/server/chromium/chromium.ts @@ -89,10 +89,8 @@ export class Chromium extends BrowserTypeBase { if (browserArguments.indexOf('--no-sandbox') !== -1) return browserArguments; const runningAsRoot = process.geteuid && process.geteuid() === 0; - if (runningAsRoot) { - console.warn('WARNING: Playwright is being run under "root" user - disabling Chromium sandbox! Run under regular user to get rid of this warning.'); + if (runningAsRoot) return ['--no-sandbox', ...browserArguments]; - } return browserArguments; } diff --git a/src/server/electron/electron.ts b/src/server/electron/electron.ts index 8341cbb0ab..ddc6918898 100644 --- a/src/server/electron/electron.ts +++ b/src/server/electron/electron.ts @@ -153,10 +153,8 @@ export class Electron { if (os.platform() === 'linux') { const runningAsRoot = process.geteuid && process.geteuid() === 0; - if (runningAsRoot && electronArguments.indexOf('--no-sandbox') === -1) { - console.warn('WARNING: Playwright is being run under "root" user - disabling Electron sandbox! Run under regular user to get rid of this warning.'); + if (runningAsRoot && electronArguments.indexOf('--no-sandbox') === -1) electronArguments.push('--no-sandbox'); - } } const { launchedProcess, gracefullyClose, kill } = await launchProcess({