mirror of
https://github.com/microsoft/playwright.git
synced 2024-09-11 20:37:54 +03:00
fix(playwright-test): have the proper default export (#7328)
There are 3 ways to import `@playwright/test` library in the modern Node.js ecosystem: - Using `require`: works great, this patch doesn't change it - Using `import` statement from `.mjs` file - we have wrong `default` for @playwright/test that should be a `test`. This is what test checks for - Using `import test from '@playwright/test'` from `.ts` file - was broken because TypeScript thought it's a CJS module, whereas it's a ESM module in reality. Also, typescript types import from `.d.ts` file was broken because we had no default export (`export *` syntax does not export default).
This commit is contained in:
parent
701624c484
commit
7caf05b24a
@ -14,9 +14,11 @@
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
import { chromium, firefox, webkit, selectors, devices, errors } from '@playwright/test';
|
||||
import playwright from '@playwright/test';
|
||||
import { chromium, firefox, webkit, selectors, devices, errors, test } from '@playwright/test';
|
||||
import * as playwright from '@playwright/test';
|
||||
import defaultExport from '@playwright/test';
|
||||
import errorsFile from '@playwright/test/lib/utils/errors.js';
|
||||
|
||||
import testESM from './esm.mjs';
|
||||
if (defaultExport !== test)
|
||||
process.exit(1);
|
||||
testESM({ chromium, firefox, webkit, selectors, devices, errors, playwright, errorsFile }, [chromium, firefox, webkit]);
|
||||
|
1
packages/playwright-test/index.d.ts
vendored
1
packages/playwright-test/index.d.ts
vendored
@ -16,3 +16,4 @@
|
||||
|
||||
export * from './types/types';
|
||||
export * from './types/test';
|
||||
export { default } from './types/test';
|
||||
|
@ -13,8 +13,13 @@
|
||||
* See the License for the specific language governing permissions and
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
module.exports = {
|
||||
...require('./lib/inprocess'),
|
||||
...require('./lib/test/index')
|
||||
const pwt = require('./lib/test/index');
|
||||
const playwright = require('./lib/inprocess');
|
||||
const combinedExports = {
|
||||
...playwright,
|
||||
...pwt,
|
||||
};
|
||||
|
||||
Object.defineProperty(combinedExports, '__esModule', { value: true });
|
||||
|
||||
module.exports = combinedExports;
|
||||
|
@ -14,7 +14,7 @@
|
||||
* limitations under the License.
|
||||
*/
|
||||
|
||||
import playwright from './index.js';
|
||||
import * as playwright from './index.js';
|
||||
|
||||
export const chromium = playwright.chromium;
|
||||
export const firefox = playwright.firefox;
|
||||
@ -25,4 +25,4 @@ export const errors = playwright.errors;
|
||||
export const _electron = playwright._electron;
|
||||
export const _android = playwright._android;
|
||||
export const test = playwright.test;
|
||||
export default playwright;
|
||||
export default playwright.default;
|
||||
|
Loading…
Reference in New Issue
Block a user