microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-11-28 01:15:10 +03:00
Code Issues Projects Releases Wiki Activity

chore: drop firefox-asan (#30626)

Browse Source
This commit is contained in:
Max Schmitt 2024-05-01 22:13:00 +00:00 committed by GitHub
parent 702bafdd88
commit 980f9c6ad4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 1 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/tests_stress.yml vendored
View File

@ -34,7 +34,6 @@ jobs:
- run: npm ci
- run: npm run build
- run: npx playwright install --with-deps
- run: npx playwright install firefox-asan
if: matrix.os != 'windows-latest'
- run: npm run stest contexts -- --project=chromium
if: ${{ !cancelled() }}

6
packages/playwright-core/browsers.json
View File

@ -19,12 +19,6 @@
"installByDefault": true,
"browserVersion": "125.0.1"
},
{
"name": "firefox-asan",
"revision": "1449",
"installByDefault": false,
"browserVersion": "125.0.1"
},
{
"name": "firefox-beta",
"revision": "1449",

45
packages/playwright-core/src/server/registry/index.ts
View File

@ -175,31 +175,6 @@ const DOWNLOAD_PATHS: Record<BrowserName | InternalTool, DownloadPaths> = {
'mac14-arm64': 'builds/firefox-beta/%s/firefox-beta-mac-13-arm64.zip',
'win64': 'builds/firefox-beta/%s/firefox-beta-win64.zip',
},
'firefox-asan': {
'<unknown>': undefined,
'ubuntu18.04-x64': undefined,
'ubuntu20.04-x64': undefined,
'ubuntu22.04-x64': 'builds/firefox/%s/firefox-asan-ubuntu-22.04.zip',
'ubuntu18.04-arm64': undefined,
'ubuntu20.04-arm64': undefined,
'ubuntu22.04-arm64': undefined,
'debian11-x64': undefined,
'debian11-arm64': undefined,
'debian12-x64': undefined,
'debian12-arm64': undefined,
'mac10.13': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac10.14': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac10.15': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac11': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac11-arm64': undefined,
'mac12': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac12-arm64': undefined,
'mac13': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac13-arm64': undefined,
'mac14': 'builds/firefox/%s/firefox-asan-mac-13.zip',
'mac14-arm64': undefined,
'win64': undefined,
},
'webkit': {
'<unknown>': undefined,
'ubuntu18.04-x64': undefined,
@ -361,7 +336,7 @@ function readDescriptors(browsersJSON: BrowsersJSON) {
}
export type BrowserName = 'chromium' | 'firefox' | 'webkit';
type InternalTool = 'ffmpeg' | 'firefox-beta' | 'firefox-asan' | 'chromium-tip-of-tree' | 'android';
type InternalTool = 'ffmpeg' | 'firefox-beta' | 'chromium-tip-of-tree' | 'android';
type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary';
const allDownloadable = ['chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree'];
@ -550,24 +525,6 @@ export class Registry {
_isHermeticInstallation: true,
});
const firefoxAsan = descriptors.find(d => d.name === 'firefox-asan')!;
const firefoxAsanExecutable = findExecutablePath(firefoxAsan.dir, 'firefox');
this._executables.push({
type: 'browser',
name: 'firefox-asan',
browserName: 'firefox',
directory: firefoxAsan.dir,
executablePath: () => firefoxAsanExecutable,
executablePathOrDie: (sdkLanguage: string) => executablePathOrDie('firefox-asan', firefoxAsanExecutable, firefoxAsan.installByDefault, sdkLanguage),
installType: firefoxAsan.installByDefault ? 'download-by-default' : 'download-on-demand',
_validateHostRequirements: (sdkLanguage: string) => this._validateHostRequirements(sdkLanguage, 'firefox', firefoxAsan.dir, ['firefox'], [], ['firefox']),
downloadURLs: this._downloadURLs(firefoxAsan),
browserVersion: firefoxAsan.browserVersion,
_install: () => this._downloadExecutable(firefoxAsan, firefoxAsanExecutable),
_dependencyGroup: 'firefox',
_isHermeticInstallation: true,
});
const firefoxBeta = descriptors.find(d => d.name === 'firefox-beta')!;
const firefoxBetaExecutable = findExecutablePath(firefoxBeta.dir, 'firefox');
this._executables.push({

1
tests/stress/playwright.config.ts
View File

@ -31,7 +31,6 @@ export default defineConfig({
name: 'firefox',
use: {
browserName: 'firefox',
channel: process.platform !== 'win32' ? 'firefox-asan' : undefined,
},
},