From 98c34ac27046d022d4e38b0225f8457e3c7955f9 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Thu, 9 Jun 2022 22:53:37 +0200 Subject: [PATCH] test: make Android green --- tests/page/matchers.misc.spec.ts | 3 ++- tests/page/page-request-fulfill.spec.ts | 9 ++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/page/matchers.misc.spec.ts b/tests/page/matchers.misc.spec.ts index 360549177c..f4bacb816e 100644 --- a/tests/page/matchers.misc.spec.ts +++ b/tests/page/matchers.misc.spec.ts @@ -16,7 +16,8 @@ import { test as it, expect } from './pageTest'; -it('should outlive frame navigation', async ({ page, server }) => { +it('should outlive frame navigation', async ({ page, server, isAndroid }) => { + it.fixme(isAndroid, 'Should be fixed when rolling the emulator'); await page.goto(server.EMPTY_PAGE); setTimeout(async () => { await page.goto(server.PREFIX + '/grid.html').catch(() => {}); diff --git a/tests/page/page-request-fulfill.spec.ts b/tests/page/page-request-fulfill.spec.ts index 4d7e308d2b..35e71b369f 100644 --- a/tests/page/page-request-fulfill.spec.ts +++ b/tests/page/page-request-fulfill.spec.ts @@ -322,8 +322,9 @@ it('headerValue should return set-cookie from intercepted response', async ({ pa expect(await response.headerValue('Set-Cookie')).toBe('a=b'); }); -it('should complain about bad har', async ({ page, server, isElectron }, testInfo) => { +it('should complain about bad har', async ({ page, server, isElectron, isAndroid }, testInfo) => { it.fixme(isElectron, 'error: Browser context management is not supported.'); + it.fixme(isAndroid); const harPath = testInfo.outputPath('test.har'); fs.writeFileSync(harPath, JSON.stringify({ log: {} }), 'utf-8'); let error; @@ -335,8 +336,9 @@ it('should complain about bad har', async ({ page, server, isElectron }, testInf expect(error.message).toContain(`Error reading HAR file ${harPath}: Cannot read`); }); -it('should complain about no entry found in har', async ({ page, server, isElectron }, testInfo) => { +it('should complain about no entry found in har', async ({ page, server, isElectron, isAndroid }, testInfo) => { it.fixme(isElectron, 'error: Browser context management is not supported.'); + it.fixme(isAndroid); const harPath = testInfo.outputPath('test.har'); fs.writeFileSync(harPath, JSON.stringify({ log: { entries: [] } }), 'utf-8'); let error; @@ -348,8 +350,9 @@ it('should complain about no entry found in har', async ({ page, server, isElect expect(error.message).toBe(`Error reading HAR file ${harPath}: No entry matching ${server.PREFIX + '/one-style.css'}`); }); -it('should complain about har + response options', async ({ page, server, isElectron }) => { +it('should complain about har + response options', async ({ page, server, isElectron, isAndroid }) => { it.fixme(isElectron, 'error: Browser context management is not supported.'); + it.fixme(isAndroid); let error; await page.route('**/*.css', async route => { const response = await page.request.fetch(route.request());