microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-27 05:46:28 +03:00
Code Issues Projects Releases Wiki Activity

fix(isVisible): do not throw when element is not connected (#8012)

Browse Source
This commit is contained in:
Max Schmitt 2021-08-05 21:10:33 +02:00 committed by GitHub
parent 19b673e467
commit 98f9f050a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/server/dom.ts
View File

@ -697,7 +697,9 @@ export class ElementHandle<T extends Node = Node> extends js.JSHandle<T> {
async isVisible(): Promise<boolean> {
const result = await this.evaluateInUtility(([injected, node]) => injected.checkElementState(node, 'visible'), {});
return throwRetargetableDOMError(throwFatalDOMError(result));
if (result === 'error:notconnected')
return false;
return throwFatalDOMError(result);
}
async isHidden(): Promise<boolean> {

19
tests/page/elementhandle-convenience.spec.ts
View File

@ -211,6 +211,25 @@ it('element state checks should work for label with zero-sized input', async ({p
expect(await page.isDisabled('text=Click me')).toBe(true);
});
it('isVisible should not throw when the DOM element is not connected', async ({page}) => {
await page.setContent(`<div id="root"></div>`);
await page.evaluate(() => {
function insert() {
document.getElementById('root').innerHTML = '<div id="problem">Problem</div>';
window.requestAnimationFrame(remove);
}
function remove() {
const node = document.getElementById('problem');
node?.parentNode?.removeChild(node);
window.requestAnimationFrame(insert);
}
window.requestAnimationFrame(insert);
});
for (let i = 0; i < 10; i++)
await page.isVisible('#problem');
});
it('isEnabled and isDisabled should work', async ({ page }) => {
await page.setContent(`
<button disabled>button1</button>