microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-27 13:50:25 +03:00
Code Issues Projects Releases Wiki Activity

roll(firefox): roll Firefox to r1174 (#4005)

Browse Source 
The r1174 starts using cross-process frameIds. This
simplifies Juggler a lot, but regresses a rare usecase:
network requests from workers from subframes are attributed
to main frame.

This adds a test to annotate this regression. Note that this
doesn't also work in Chromium.

References #3995
This commit is contained in:
Andrey Lushnikov 2020-09-29 21:07:25 -07:00 committed by GitHub
parent d658b687ca
commit a20c0e0adb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browsers.json
View File

@ -8,7 +8,7 @@
},
{
"name": "firefox",
"revision": "1173",
"revision": "1174",
"download": true
},
{

18
test/workers.spec.ts
View File

@ -16,6 +16,7 @@
*/
import { it, expect } from './fixtures';
import { attachFrame } from './utils';
import type { ConsoleMessage } from '..';
it('Page.workers', async function({page, server}) {
@ -106,6 +107,23 @@ it('should clear upon cross-process navigation', async function({server, page})
expect(page.workers().length).toBe(0);
});
it('should attribute network activity for worker inside iframe to the iframe', (test, {browserName}) => {
test.fixme(browserName === 'firefox' || browserName === 'chromium');
}, async function({page, server}) {
await page.goto(server.PREFIX + '/empty.html');
const [worker, frame] = await Promise.all([
page.waitForEvent('worker'),
attachFrame(page, 'frame1', server.PREFIX + '/worker/worker.html'),
]);
const url = server.PREFIX + '/one-style.css';
const [request] = await Promise.all([
page.waitForRequest(url),
worker.evaluate(url => fetch(url).then(response => response.text()).then(console.log), url),
]);
expect(request.url()).toBe(url);
expect(request.frame()).toBe(frame);
});
it('should report network activity', async function({page, server}) {
const [worker] = await Promise.all([
page.waitForEvent('worker'),