microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 21:53:35 +03:00
Code Issues Projects Releases Wiki Activity

fix(testrunner): do not spam output after termination (#1511)

Browse Source
This commit is contained in:
Dmitry Gozman 2020-03-24 14:40:59 -07:00 committed by GitHub
parent 3e8a6ac347
commit a2ee7a1f2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
utils/testrunner/TestRunner.js
View File

@ -293,7 +293,8 @@ class TestWorker {
message = `${location} - Timeout Exceeded ${hook.timeout}ms while running "${hookName}" in suite "${suite.fullName}"`;
error = null;
} else if (error === TerminatedError) {
message = `${location} - TERMINATED while running "${hookName}" in suite "${suite.fullName}"`;
// Do not report termination details - it's just noise.
message = '';
error = null;
} else {
if (error.stack)
@ -408,6 +409,8 @@ class TestPass {
for (const worker of this._workers)
worker.terminate(force /* terminateHooks */);
this._result.setResult(result, message);
if (this._result.message === 'SIGINT received' && message === 'SIGTERM received')
this._result.message = message;
if (error) {
if (error.stack)
await this._runner._sourceMapSupport.rewriteStackTraceWithSourceMaps(error);
@ -439,7 +442,8 @@ class TestPass {
async _didFailHook(worker, suite, hook, hookName, message, error) {
debug('testrunner:hook')(`[${worker._workerId}] "${hookName}" FAILED for "${suite.fullName}" (${hook.location.fileName + ':' + hook.location.lineNumber})`);
this._result.addError(message, error, worker);
if (message)
this._result.addError(message, error, worker);
this._result.setResult(TestResult.Crashed, message);
}