microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-01-06 03:16:17 +03:00
Code Issues Projects Releases Wiki Activity

test: update expectations of requestStorageAccess (#17780)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/17285
This commit is contained in:
Yury Semikhatsky 2022-10-03 20:46:47 -07:00 committed by GitHub
parent cb6b824119
commit a9ef95f31e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/library/browsercontext-cookies.spec.ts
View File

@ -350,10 +350,9 @@ it('should be able to send third party cookies via an iframe', async ({ browser,
} }
}); });
it('should support requestStorageAccess', async ({ page, server, browserName, isMac }) => { it('should support requestStorageAccess', async ({ page, server, browserName, isMac, isLinux, isWindows }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/17285' }); it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/17285' });
it.skip(browserName === 'chromium', 'requestStorageAccess API is not available in Chromium'); it.skip(browserName === 'chromium', 'requestStorageAccess API is not available in Chromium');
it.fixme(browserName === 'webkit' && isMac, 'Have to accept dialog');
server.setRoute('/set-cookie.html', (req, res) => { server.setRoute('/set-cookie.html', (req, res) => {
res.setHeader('Set-Cookie', 'name=value; Path=/'); res.setHeader('Set-Cookie', 'name=value; Path=/');
res.end(); res.end();
@ -375,13 +374,19 @@ it('should support requestStorageAccess', async ({ page, server, browserName, is
} }
return; return;
} else { } else {
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeFalsy(); if (isLinux && browserName === 'webkit')
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy();
else
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeFalsy();
{ {
const [serverRequest] = await Promise.all([ const [serverRequest] = await Promise.all([
server.waitForRequest('/title.html'), server.waitForRequest('/title.html'),
frame.evaluate(() => fetch('/title.html')) frame.evaluate(() => fetch('/title.html'))
]); ]);
expect(serverRequest.headers.cookie).toBeFalsy(); if (!isMac && browserName === 'webkit')
expect(serverRequest.headers.cookie).toBe('name=value');
else
expect(serverRequest.headers.cookie).toBeFalsy();
} }
expect(await frame.evaluate(() => document.requestStorageAccess().then(() => true, e => false))).toBeTruthy(); expect(await frame.evaluate(() => document.requestStorageAccess().then(() => true, e => false))).toBeTruthy();
expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy(); expect(await frame.evaluate(() => document.hasStorageAccess())).toBeTruthy();