microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 13:45:36 +03:00
Code Issues Projects Releases Wiki Activity

test: minor fixes (#4024)

Browse Source 
- missing await
- missing `defaultBrowserOptions` that's important to respect `FFPATH` (and other custom browsers)
This commit is contained in:
Andrey Lushnikov 2020-09-30 17:23:13 -07:00 committed by GitHub
parent 13d48da84a
commit b9dcfb9909
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/channels.spec.ts
View File

@ -162,8 +162,8 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions})
await expectScopeState(browserType, GOLDEN_PRECONDITION);
});
it('should work with the domain module', async ({ domain, browserType }) => {
const browser = await browserType.launch();
it('should work with the domain module', async ({ domain, browserType, defaultBrowserOptions }) => {
const browser = await browserType.launch(defaultBrowserOptions);
const page = await browser.newPage();
const result = await page.evaluate(() => 1 + 1);
expect(result).toBe(2);

2
test/downloads-path.spec.ts
View File

@ -52,7 +52,7 @@ defineTestFixture('persistentDownloadsContext', async ({server, launchPersistent
acceptDownloads: true
}
);
page.setContent(`<a href="${server.PREFIX}/download">download</a>`);
await page.setContent(`<a href="${server.PREFIX}/download">download</a>`);
await test(context);
await context.close();
});