From c42a1205b1060e9b9c75754f482bc86609e3771b Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Wed, 1 Mar 2023 13:44:58 -0800 Subject: [PATCH] chore: do not generate history entries on snapshot switch (#21283) --- packages/trace-viewer/src/ui/snapshotTab.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/trace-viewer/src/ui/snapshotTab.tsx b/packages/trace-viewer/src/ui/snapshotTab.tsx index 9aaa4d50ad..1446e4ad43 100644 --- a/packages/trace-viewer/src/ui/snapshotTab.tsx +++ b/packages/trace-viewer/src/ui/snapshotTab.tsx @@ -91,7 +91,12 @@ export const SnapshotTab: React.FunctionComponent<{ if (!iframeRef.current) return; try { - iframeRef.current.src = snapshotUrl + (pointX === undefined ? '' : `&pointX=${pointX}&pointY=${pointY}`); + const newUrl = snapshotUrl + (pointX === undefined ? '' : `&pointX=${pointX}&pointY=${pointY}`); + // Try preventing history entry from being created. + if (iframeRef.current.contentWindow) + iframeRef.current.contentWindow.location.replace(newUrl); + else + iframeRef.current.src = newUrl; } catch (e) { } })();