microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-14 13:45:36 +03:00
Code Issues Projects Releases Wiki Activity

fix(types): add missing properties to DeviceDescriptor (#3332)

Browse Source
This commit is contained in:
Joel Einbinder 2020-08-06 15:45:13 -07:00 committed by GitHub
parent 83ac3f43f3
commit c9409bf1b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
utils/generate_types/overrides.d.ts vendored
View File

@ -168,7 +168,13 @@ export interface CDPSession {
): Promise<Protocol.CommandReturnValues[T]>; ): Promise<Protocol.CommandReturnValues[T]>;
} }
type DeviceDescriptor = {viewport: BrowserNewContextOptionsViewport, userAgent: string}; type DeviceDescriptor = {
viewport: BrowserNewContextOptionsViewport;
userAgent: string;
deviceScaleFactor: number;
isMobile: boolean;
hasTouch: boolean;
};
export namespace errors { export namespace errors {

10
utils/generate_types/test/test.ts
View File

@ -714,11 +714,17 @@ playwright.chromium.launch().then(async browser => {
{ {
playwright.devices['my device'] = { playwright.devices['my device'] = {
userAgent: 'foo', userAgent: 'foo',
viewport: {height: 123, width: 456} viewport: {height: 123, width: 456},
deviceScaleFactor: 1,
hasTouch: false,
isMobile: true,
}; };
const iPhone = playwright.devices['iPhone 11']; const iPhone = playwright.devices['iPhone 11'];
const assertion: AssertType<string, typeof iPhone.userAgent> = true; const assertion: AssertType<string, typeof iPhone.userAgent> = true;
const numberAssertion: AssertType<number, typeof iPhone.viewport.width> = true; const widthAssertion: AssertType<number, typeof iPhone.viewport.width> = true;
const deviceScaleFactorAssertion: AssertType<number, typeof iPhone.deviceScaleFactor> = true;
const hasTouchAssertion: AssertType<boolean, typeof iPhone.hasTouch> = true;
const isMobileAssertion: AssertType<boolean, typeof iPhone.isMobile> = true;
} }
{ {
const agents = playwright.devices.map(x => x.userAgent); const agents = playwright.devices.map(x => x.userAgent);