microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-03 07:51:12 +03:00
Code Issues Projects Releases Wiki Activity

fix(ct): solid and react JS as child (#20125)

Browse Source
This commit is contained in:
Sander 2023-03-02 22:40:51 +01:00 committed by GitHub
parent 0b300f455c
commit d58d833daf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 50 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/playwright-ct-react/registerSource.mjs
View File

@ -36,9 +36,11 @@ export function register(components) {
/**
* @param {Component} component
* @returns {JSX.Element}
*/
function render(component) {
if (typeof component !== 'object' || Array.isArray(component))
return component;
let componentFunc = registry.get(component.type);
if (!componentFunc) {
// Lookup by shorthand.

2
packages/playwright-ct-solid/registerSource.mjs
View File

@ -42,7 +42,7 @@ function createChild(child) {
* @param {Component} component
*/
function createComponent(component) {
if (typeof component === 'string')
if (typeof component !== 'object' || Array.isArray(component))
return component;
let Component = registry.get(component.type);

2
packages/playwright-test/types/component.d.ts vendored
View File

@ -34,7 +34,7 @@ export type ObjectComponent = {
options?: MountOptions
};
export type Component = JsxComponent | ObjectComponent;
export type Component = JsxComponent | ObjectComponent | number | string | Array<any>;
declare global {
interface Window {

15
tests/components/ct-react-vite/tests/children.spec.tsx
View File

@ -42,3 +42,18 @@ test('render named children', async ({ mount }) => {
await expect(component).toContainText('Main Content');
await expect(component).toContainText('Footer');
});
test('render string as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{'string'}</DefaultChildren>);
await expect(component).toContainText('string');
});
test('render array as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{[4,2]}</DefaultChildren>);
await expect(component).toContainText('42');
});
test('render number as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{1337}</DefaultChildren>);
await expect(component).toContainText('1337');
});

15
tests/components/ct-react/tests/children.spec.tsx
View File

@ -42,3 +42,18 @@ test('render named children', async ({ mount }) => {
await expect(component).toContainText('Main Content');
await expect(component).toContainText('Footer');
});
test('render string as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{'string'}</DefaultChildren>);
await expect(component).toContainText('string');
});
test('render array as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{[4,2]}</DefaultChildren>);
await expect(component).toContainText('42');
});
test('render number as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{1337}</DefaultChildren>);
await expect(component).toContainText('1337');
});

15
tests/components/ct-solid/tests/children.spec.tsx
View File

@ -42,3 +42,18 @@ test('render named children', async ({ mount }) => {
await expect(component).toContainText('Main Content');
await expect(component).toContainText('Footer');
});
test('render string as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{'string'}</DefaultChildren>);
await expect(component).toContainText('string');
});
test('render array as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{[4,2]}</DefaultChildren>);
await expect(component).toContainText('42');
});
test('render number as child', async ({ mount }) => {
const component = await mount(<DefaultChildren>{1337}</DefaultChildren>);
await expect(component).toContainText('1337');
});