From d7366cfc7c68a9c2f9454c99e305f0dc2e8cf532 Mon Sep 17 00:00:00 2001 From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com> Date: Wed, 25 Jan 2023 01:23:12 -0800 Subject: [PATCH] feat(chromium-tip-of-tree): roll to r1080 (#20323) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Schmitt --- packages/playwright-core/browsers.json | 4 ++-- tests/library/permissions.spec.ts | 2 +- tests/page/frame-goto.spec.ts | 7 +++++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index c363ef9349..0962fd4255 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -15,9 +15,9 @@ }, { "name": "chromium-tip-of-tree", - "revision": "1079", + "revision": "1080", "installByDefault": false, - "browserVersion": "111.0.5547.0" + "browserVersion": "111.0.5557.0" }, { "name": "firefox", diff --git a/tests/library/permissions.spec.ts b/tests/library/permissions.spec.ts index e22d10a8f0..69be0070a3 100644 --- a/tests/library/permissions.spec.ts +++ b/tests/library/permissions.spec.ts @@ -122,7 +122,7 @@ it.describe('permissions', () => { // Note: Chromium 110 stopped triggering "onchange" when clearing permissions. expect(await page.evaluate(() => window['events'])).toEqual( - (browserName === 'chromium' && browserMajorVersion >= 110) ? + (browserName === 'chromium' && browserMajorVersion === 110) ? ['prompt', 'denied', 'granted'] : ['prompt', 'denied', 'granted', 'prompt']); }); diff --git a/tests/page/frame-goto.spec.ts b/tests/page/frame-goto.spec.ts index cb9620c6e6..7434213ac7 100644 --- a/tests/page/frame-goto.spec.ts +++ b/tests/page/frame-goto.spec.ts @@ -28,7 +28,7 @@ it('should navigate subframes @smoke', async ({ page, server }) => { expect(response.frame()).toBe(page.frames()[1]); }); -it('should reject when frame detaches', async ({ page, server }) => { +it('should reject when frame detaches', async ({ page, server, browserName }) => { await page.goto(server.PREFIX + '/frames/one-frame.html'); server.setRoute('/empty.html', () => {}); @@ -37,7 +37,10 @@ it('should reject when frame detaches', async ({ page, server }) => { await page.$eval('iframe', frame => frame.remove()); const error = await navigationPromise; - expect(error.message).toContain('frame was detached'); + if (browserName === 'chromium') + expect(error.message.includes('net::ERR_ABORTED') || error.message.includes('frame was detached')).toBe(true); + else + expect(error.message).toContain('frame was detached'); }); it('should continue after client redirect', async ({ page, server, isAndroid }) => {