From d9a00342c84be6618b07315911e74cac22efda64 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Thu, 29 Feb 2024 09:02:05 -0800 Subject: [PATCH] fix(HEAD): revert GET->HEAD migration, net-effect was negative (#29738) Fixes: https://github.com/microsoft/playwright/issues/29732 --- packages/playwright-core/src/utils/network.ts | 3 +-- tests/playwright-test/web-server.spec.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/playwright-core/src/utils/network.ts b/packages/playwright-core/src/utils/network.ts index bf834abaa0..8cacb8aeb6 100644 --- a/packages/playwright-core/src/utils/network.ts +++ b/packages/playwright-core/src/utils/network.ts @@ -181,9 +181,8 @@ export async function isURLAvailable(url: URL, ignoreHTTPSErrors: boolean, onLog async function httpStatusCode(url: URL, ignoreHTTPSErrors: boolean, onLog?: (data: string) => void, onStdErr?: (data: string) => void): Promise { return new Promise(resolve => { - onLog?.(`HTTP HEAD: ${url}`); + onLog?.(`HTTP GET: ${url}`); httpRequest({ - method: 'HEAD', url: url.toString(), headers: { Accept: '*/*' }, rejectUnauthorized: !ignoreHTTPSErrors diff --git a/tests/playwright-test/web-server.spec.ts b/tests/playwright-test/web-server.spec.ts index d2eacb2d55..04e3c1d328 100644 --- a/tests/playwright-test/web-server.spec.ts +++ b/tests/playwright-test/web-server.spec.ts @@ -662,7 +662,7 @@ test('should check ipv4 and ipv6 with happy eyeballs when URL is passed', async expect(result.exitCode).toBe(0); expect(result.passed).toBe(1); expect(result.output).toContain('Process started'); - expect(result.output).toContain(`HTTP HEAD: http://localhost:${port}/`); + expect(result.output).toContain(`HTTP GET: http://localhost:${port}/`); expect(result.output).toContain('WebServer available'); });