diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index b117bb2267..a76dc9fd3c 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -131,11 +131,11 @@ jobs: - run: npx playwright install --with-deps - run: npm run ttest -- --shard ${{ matrix.shard }} env: - PWTEST_BOT_NAME: "${{ matrix.os }}-node${{ matrix.node-version }}" + PWTEST_BOT_NAME: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shard }}" if: matrix.os != 'ubuntu-latest' - run: xvfb-run npm run ttest -- --shard ${{ matrix.shard }} env: - PWTEST_BOT_NAME: "${{ matrix.os }}-node${{ matrix.node-version }}" + PWTEST_BOT_NAME: "${{ matrix.os }}-node${{ matrix.node-version }}-${{ matrix.shard }}" if: matrix.os == 'ubuntu-latest' - run: ./utils/upload_flakiness_dashboard.sh ./test-results/report.json if: always() diff --git a/packages/playwright/src/reporters/blob.ts b/packages/playwright/src/reporters/blob.ts index f15fe6f87d..192b639a5a 100644 --- a/packages/playwright/src/reporters/blob.ts +++ b/packages/playwright/src/reporters/blob.ts @@ -109,12 +109,14 @@ export class BlobReporter extends TeleReporterEmitter { } private _computeReportName(config: FullConfig) { - let reportName = this._options.fileName ?? 'report.zip'; + if (this._options.fileName) + return this._options.fileName; + let reportName = 'report'; if (config.shard) { const paddedNumber = `${config.shard.current}`.padStart(`${config.shard.total}`.length, '0'); - reportName = `${reportName.slice(0, -4)}-${paddedNumber}.zip`; + reportName = `${reportName}-${paddedNumber}`; } - return reportName; + return `${reportName}.zip`; } override _serializeAttachments(attachments: TestResult['attachments']): JsonAttachment[] {