microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-07-07 08:56:42 +03:00
Code Issues Projects Releases Wiki Activity

feat(trace-viewer) add request urls for actions initiated via APIRequestContext (#31534)

Browse Source
This commit is contained in:
ryanrosello-og 2024-07-04 17:59:56 +08:00 committed by GitHub
parent 1c69d3e175
commit e36ebb6ede
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/trace-viewer/src/ui/actionList.tsx
View File

@ -102,6 +102,7 @@ export const renderAction = (
<span>{action.apiName}</span>
{locator && <div className='action-selector' title={locator}>{locator}</div>}
{action.method === 'goto' && action.params.url && <div className='action-url' title={action.params.url}>{action.params.url}</div>}
{action.class === 'APIRequestContext' && action.params.url && <div className='action-url' title={action.params.url}>{excludeOrigin(action.params.url)}</div>}
</div>
{(showDuration || showBadges) && <div className='spacer'></div>}
{showDuration && <div className='action-duration'>{time || <span className='codicon codicon-loading'></span>}</div>}
@ -111,3 +112,12 @@ export const renderAction = (
</div>}
</>;
};
function excludeOrigin(url: string): string {
try {
const urlObject = new URL(url);
return urlObject.pathname + urlObject.search;
} catch (error) {
return url;
}
}

6
tests/library/trace-viewer.spec.ts
View File

@ -812,12 +812,12 @@ test('should open two trace files', async ({ context, page, request, server, sho
await traceViewer.selectAction('apiRequestContext.get');
await traceViewer.selectAction('apiRequestContext.post');
await expect(traceViewer.actionTitles).toHaveText([
`apiRequestContext.get`,
`apiRequestContext.get/simple.json`,
`page.gotohttp://localhost:${server.PORT}/input/button.html`,
`apiRequestContext.head`,
`apiRequestContext.head/simplezip.json`,
`locator.clicklocator('button')`,
`locator.clicklocator('button')`,
`apiRequestContext.post`,
`apiRequestContext.post/one-style.css`,
]);
await traceViewer.page.locator('text=Metadata').click();