microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-12 11:50:22 +03:00
Code Issues Projects Releases Wiki Activity

fix(page.content): throw a nice error when navigation intervenes (#9080)

Browse Source
This commit is contained in:
Dmitry Gozman 2021-09-22 10:40:15 -07:00 committed by GitHub
parent 449a593050
commit e85a3a5a41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 30 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/server/frames.ts
View File

@ -769,8 +769,9 @@ export class Frame extends SdkObject {
}
async content(): Promise<string> {
try {
const context = await this._utilityContext();
return context.evaluate(() => {
return await context.evaluate(() => {
let retVal = '';
if (document.doctype)
retVal = new XMLSerializer().serializeToString(document.doctype);
@ -778,6 +779,11 @@ export class Frame extends SdkObject {
retVal += document.documentElement.outerHTML;
return retVal;
});
} catch (e) {
if (js.isJavaScriptErrorInEvaluate(e) || isSessionClosedError(e))
throw e;
throw new Error(`Unable to retrieve content because the page is navigating and changing the content.`);
}
}
async setContent(metadata: CallMetadata, html: string, options: types.NavigateOptions = {}): Promise<void> {

15
tests/page/page-set-content.spec.ts
View File

@ -101,3 +101,18 @@ it('should work with newline', async ({page, server}) => {
await page.setContent('<div>\n</div>');
expect(await page.$eval('div', div => div.textContent)).toBe('\n');
});
it('content() should throw nice error during navigation', async ({page, server}) => {
for (let timeout = 0; timeout < 200; timeout += 20) {
await page.setContent('<div>hello</div>');
const promise = page.goto(server.EMPTY_PAGE);
await page.waitForTimeout(timeout);
const [contentOrError] = await Promise.all([
page.content().catch(e => e),
promise,
]);
const emptyOutput = '<html><head></head><body></body></html>';
if (contentOrError !== expectedOutput && contentOrError !== emptyOutput)
expect(contentOrError?.message).toContain('Unable to retrieve content because the page is navigating and changing the content.');
}
});