microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-10-26 21:33:38 +03:00
Code Issues Projects Releases Wiki Activity

fix(ct): allow importing components from node_modules (#30493)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/29854
This commit is contained in:
Pavel Feldman 2024-04-24 12:32:28 -07:00 committed by GitHub
parent 7a9fd27146
commit e91d372544
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-ct-core/src/viteUtils.ts
View File

@ -183,7 +183,7 @@ export function transformIndexFile(id: string, content: string, templateDir: str
lines.push(registerSource);
for (const value of importInfos.values()) {
const importPath = resolveHook(value.filename, value.importSource);
const importPath = resolveHook(value.filename, value.importSource) || value.importSource;
lines.push(`const ${value.id} = () => import('${importPath?.replaceAll(path.sep, '/')}').then((mod) => mod.${value.remoteName || 'default'});`);
}

30
tests/playwright-test/playwright.ct-build.spec.ts
View File

@ -665,3 +665,33 @@ test('should pass undefined value as param', async ({ runInlineTest }) => {
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
});
test('should resolve components imported from node_modules', async ({ runInlineTest }) => {
const result = await runInlineTest({
'package.json': `{ "name": "test-project" }`,
'playwright.config.ts': playwrightCtConfigText,
'playwright/index.html': `<script type="module" src="./index.js"></script>`,
'playwright/index.js': ``,
'node_modules/@mui/material/index.js': `
const TextField = () => 'input';
module.exports = { TextField };
`,
'node_modules/@mui/material/package.json': JSON.stringify({
name: '@mui/material',
main: './index.js',
}),
'src/component.spec.tsx': `
import { test } from '@playwright/experimental-ct-react';
import { TextField } from '@mui/material';
test("passes", async ({ mount }) => {
await mount(<TextField />);
});
`,
}, { workers: 1 });
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
});