From eb3efb30893ec14a05b7858e1253d01cd2e5fec6 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 19 Feb 2021 21:31:33 -0800 Subject: [PATCH] fix: do not ship broken symlinks in webkit for mac (#5512) Since we don't ship things like WebKitPluginAgent, we can safely remove all the symlinks that point to the missing targets. Fixes #5472 --- browser_patches/webkit/BUILD_NUMBER | 4 ++-- browser_patches/webkit/archive.sh | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/browser_patches/webkit/BUILD_NUMBER b/browser_patches/webkit/BUILD_NUMBER index 45ad536dce..b8849722c5 100644 --- a/browser_patches/webkit/BUILD_NUMBER +++ b/browser_patches/webkit/BUILD_NUMBER @@ -1,2 +1,2 @@ -1437 -Changed: dgozman@gmail.com Fri Feb 19 16:12:07 PST 2021 +1438 +Changed: lushnikov@chromium.com Fri Feb 19 21:08:07 PST 2021 diff --git a/browser_patches/webkit/archive.sh b/browser_patches/webkit/archive.sh index 0d640216ba..adec84818e 100755 --- a/browser_patches/webkit/archive.sh +++ b/browser_patches/webkit/archive.sh @@ -131,6 +131,9 @@ createZipForMac() { # copy protocol node $SCRIPTS_DIR/concat_protocol.js > $tmpdir/protocol.json + # Remove all broken symlinks. @see https://github.com/microsoft/playwright/issues/5472 + find "${tmpdir}" -type l ! -exec test -e {} \; -print | xargs rm + # zip resulting directory and cleanup TMP. ditto -c -k $tmpdir $ZIP_PATH rm -rf $tmpdir