From f223a98e3db20efdc366fff6043a0003fd1a762f Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Thu, 21 Nov 2019 21:16:00 -0800 Subject: [PATCH] feat(chromium): roll Chromium to r717627 (#49) --- package.json | 2 +- src/tests/accessibility.spec.js | 25 ++++++++++++++++++------- utils/check_availability.js | 2 +- 3 files changed, 20 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index f88ad41540..4763df4018 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "node": ">=8.16.0" }, "playwright": { - "chromium_revision": "706915", + "chromium_revision": "717627", "firefox_revision": "1", "webkit_revision": "2" }, diff --git a/src/tests/accessibility.spec.js b/src/tests/accessibility.spec.js index f365436552..b1bafc3174 100644 --- a/src/tests/accessibility.spec.js +++ b/src/tests/accessibility.spec.js @@ -102,7 +102,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { focused: true, multiline: true, children: [{ - role: 'GenericContainer', + role: 'generic', name: '', children: [{ role: 'text', name: 'hi' @@ -184,7 +184,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { name: 'my fake image' }] } : { - role: 'GenericContainer', + role: 'generic', name: '', value: 'Edit this image: ', children: [{ @@ -243,7 +243,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) {
Edit this image:my fake image
`); const snapshot = await page.accessibility.snapshot(); expect(snapshot.children[0]).toEqual({ - role: 'GenericContainer', + role: 'generic', name: '' }); }); @@ -252,7 +252,7 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) {
Edit this image:my fake image
`); const snapshot = await page.accessibility.snapshot(); expect(snapshot.children[0]).toEqual({ - role: 'GenericContainer', + role: 'generic', name: '' }); }); @@ -362,10 +362,21 @@ module.exports.addTests = function({testRunner, expect, FFOX, CHROME, WEBKIT}) { const div = await page.$('div'); expect(await page.accessibility.snapshot({root: div})).toEqual(null); expect(await page.accessibility.snapshot({root: div, interestingOnly: false})).toEqual({ - role: 'GenericContainer', + role: 'generic', name: '', - children: [ { role: 'button', name: 'My Button' } ] } - ); + children: [ + { + role: 'button', + name: 'My Button', + children: [ + { + role: "text", + name: "My Button" + } + ], + } + ] + }); }); }); }); diff --git a/utils/check_availability.js b/utils/check_availability.js index 7073cbf2d8..516578b631 100755 --- a/utils/check_availability.js +++ b/utils/check_availability.js @@ -16,7 +16,7 @@ */ const assert = require('assert'); -const playwright = require('..'); +const playwright = require('../chromium'); const https = require('https'); const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64'];