microsoft/playwright
1
1
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2024-12-16 07:33:35 +03:00
Code Issues Projects Releases Wiki Activity

fix(recorder): allow node to close gracefully (#2817)

Browse Source
This commit is contained in:
Joel Einbinder 2020-07-02 08:02:27 -07:00 committed by GitHub
parent cb0c037e17
commit f484b20eea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/debug/recorderController.ts
View File

@ -28,6 +28,7 @@ export class RecorderController {
private _performingAction = false; private _performingAction = false;
private _pageAliases = new Map<Page, string>(); private _pageAliases = new Map<Page, string>();
private _lastPopupOrdinal = 0; private _lastPopupOrdinal = 0;
private _timers = new Set<NodeJS.Timeout>();
constructor(context: BrowserContextBase, output: Writable) { constructor(context: BrowserContextBase, output: Writable) {
this._output = new TerminalOutput(output || process.stdout); this._output = new TerminalOutput(output || process.stdout);
@ -49,6 +50,12 @@ export class RecorderController {
page.on(Events.Page.FrameNavigated, (frame: frames.Frame) => this._onFrameNavigated(frame)); page.on(Events.Page.FrameNavigated, (frame: frames.Frame) => this._onFrameNavigated(frame));
page.on(Events.Page.Popup, (popup: Page) => this._onPopup(page, popup)); page.on(Events.Page.Popup, (popup: Page) => this._onPopup(page, popup));
}); });
context.once(Events.BrowserContext.Close, () => {
for (const timer of this._timers)
clearTimeout(timer);
this._timers.clear();
});
} }
private async _performAction(frame: frames.Frame, action: actions.Action) { private async _performAction(frame: frames.Frame, action: actions.Action) {
@ -70,7 +77,11 @@ export class RecorderController {
if (action.name === 'select') if (action.name === 'select')
await frame.selectOption(action.selector, action.options); await frame.selectOption(action.selector, action.options);
this._performingAction = false; this._performingAction = false;
setTimeout(() => action.committed = true, 5000); const timer = setTimeout(() => {
action.committed = true;
this._timers.delete(timer);
}, 5000);
this._timers.add(timer);
} }
private async _recordAction(frame: frames.Frame, action: actions.Action) { private async _recordAction(frame: frames.Frame, action: actions.Action) {